@jackpot51 @4lDO2 I forked this working on redox_users, so I don't think it's used anyplace else and the fork is very out of date (the source on pijul.org is even gone now). Was reminded by https://github.com/redox-os/cryptovec/pull/1. This should be archived or deleted.
SamwiseFilmore (71f997d2) at 22 Nov 18:45
Set min user/group name length
Hello,
I'm trying to build redox_users on debian. Can I fix this somehow?
Compiling redox_syscall v0.1.56
Running `CARGO_PKG_VERSION=0.1.56 CARGO_PKG_REPOSITORY='https://gitlab.redox-os.org/redox-os/syscall' CARGO=/usr/bin/cargo CARGO_PKG_VERSION_PRE= CARGO_PKG_AUTHORS='Jeremy Soller <jackpot51@gmail.com>' CARGO_PKG_VERSION_MINOR=1 CARGO_PKG_NAME=redox_syscall CARGO_MANIFEST_DIR=/<<PKGBUILDDIR>>/debian/cargo_registry/redox_syscall-0.1.56 LD_LIBRARY_PATH='/<<PKGBUILDDIR>>/target/debug/deps:/usr/lib' CARGO_PKG_HOMEPAGE= CARGO_PKG_VERSION_PATCH=56 CARGO_PKG_DESCRIPTION='A Rust library to access raw Redox system calls' CARGO_PKG_VERSION_MAJOR=0 rustc --crate-name syscall /<<PKGBUILDDIR>>/debian/cargo_registry/redox_syscall-0.1.56/src/lib.rs --color never --crate-type lib --emit=dep-info,link -C debuginfo=2 -C metadata=c20a21f895147fe7 -C extra-filename=-c20a21f895147fe7 --out-dir /<<PKGBUILDDIR>>/target/x86_64-unknown-linux-gnu/debug/deps --target x86_64-unknown-linux-gnu -L dependency=/<<PKGBUILDDIR>>/target/x86_64-unknown-linux-gnu/debug/deps -L dependency=/<<PKGBUILDDIR>>/target/debug/deps --cap-lints warn -C debuginfo=2 --cap-lints warn -C linker=x86_64-linux-gnu-gcc -C link-arg=-Wl,-z,relro --remap-path-prefix /<<PKGBUILDDIR>>=/usr/share/cargo/registry/redox-users-0.3.0`
error[E0554]: #![feature] may not be used on the stable release channel
--> /usr/share/cargo/registry/redox-users-0.3.0/debian/cargo_registry/redox_syscall-0.1.56/src/lib.rs:1:1
|
1 | #![feature(asm)]
| ^^^^^^^^^^^^^^^^
error[E0554]: #![feature] may not be used on the stable release channel
--> /usr/share/cargo/registry/redox-users-0.3.0/debian/cargo_registry/redox_syscall-0.1.56/src/lib.rs:2:1
|
2 | #![feature(const_fn)]
| ^^^^^^^^^^^^^^^^^^^^^
error: aborting due to 2 previous errors
For more information about this error, try `rustc --explain E0554`.
error: Could not compile `redox_syscall`.
This is a security critical crate, I think it's probably important that memory is zeroed before it is freed. I'm no crypto expert though, so I'd probably differ to somebody else on this one.
SamwiseFilmore (bd6865d2) at 22 Nov 06:15
Limit name length; Zero sensitive mem; Resolves #22
SamwiseFilmore (bc5d7bb5) at 21 Nov 22:32
Refactor auth stuff to auth::Full
I've made this change based on your code in my recent commits, thanks for the head start. I'm going to close this since the feature is implemented.
I read the comment of @MggMuggins here: !28 (comment 14322). Then I doubt that the purpose of @mmstick is the best in term of speed. For the moment I do not matter the speed. I choose to set some arguments to optional.
Things that I want to do better for the 1.0.0
release. I'm not about to release that though, I want to iterate on this library for a while. If anybody wants to I'm happy to let somebody have a crack at this issue.
Display
and FromStr
into some internal traits so that they're not exposed in the API. Parsing these library types are implementation details that this library should be abstracting away.Group
unconstructable and add a new
method for User
and Group
that allows easy-ish construction. Along with this, refactor the AllGroups::add_group
and AllUsers::add_user
so that they just take a User
or a Group
. This should simplify the API and make it more consistent. Also allows for more efficient use of the library.UserBuilder
/GroupBuilder
), which would ensure that all their inputs are valid before building a new user. Might be nice to implement construction as User::builder() -> UserBuilder
for ergonomic reasons.UserBuilder
/GroupBuilder
from AllUsers
/AllGroups
, and cause it to hold a mutable reference to its AllUsers
/AllGroups
. Consuming the Builder then modifies the All
.redox_users::Result
and just use Result<T, failure::Error>
thiserror
to derive error for the library's error type, and provide more/better context for that error type.Debug
for AllGroups
and fix the implementation for AllUsers
. It works right now, but it's not pretty.Finally implemented this, there are probably a few pain points yet but I'm going to go ahead and close this issue.
SamwiseFilmore (42a9cc67) at 17 Nov 21:10
UserBuilder and improve GroupBuilder
... and 1 more commit
I was unpleasantly surprised to discover that sodiumoxide is now archived. Apparently the author will still be fixing security issues but I think that's an indication that pkgar should move to a different library for crypto stuff. I did a little poking around and didn't find anything that looked super reliable, may have to go back to the C library bindings for libsodium.
SamwiseFilmore (133646ac) at 05 Nov 00:09
Merge branch 'master' into builder_and_split_sources
... and 2 more commits
This is blocking on users#24 (closed)
SamwiseFilmore (0c0aa91c) at 30 Apr 16:28
SamwiseFilmore (43b708e9) at 26 Apr 01:16
Small fixes according to robweb's review
SamwiseFilmore (f4f19301) at 25 Apr 19:46
Comments
I think this should significantly ease the process of getting programs running in redox and playing around with schemes for new users. Depends on cookbook!250
If you're interested please give it a proofread, there are probably typos or something like that around.
SamwiseFilmore (16ac8dbc) at 25 Apr 19:43
Rewrite compiling a program and scheme example