From 7abe992f1cd5da5a6d2e35baae4b930193934017 Mon Sep 17 00:00:00 2001 From: Xavier L'Heureux <xavier.lheureux@icloud.com> Date: Tue, 26 Mar 2019 10:22:30 -0400 Subject: [PATCH] Fix tests for performance improvements --- ci/run_benchmark.sh | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/ci/run_benchmark.sh b/ci/run_benchmark.sh index bc7b8080..703136dc 100755 --- a/ci/run_benchmark.sh +++ b/ci/run_benchmark.sh @@ -30,15 +30,12 @@ for suite in ./target/criterion/*; do for test in $suite/*/*/change/estimates.json; do estimate=$(cat "$test" | jq -r "$JQ_FILTER" -c) - case "$estimate" in - -*);; - *) - inner="<failure message=\"Performance Regressed\" type=\"WARNING\">\ - Performance regressed by $estimate in $test\ - </failure>" - worse=$((worse+1)) - ;; - esac + if echo "$estimate" | grep -Eq '^[0-9]+\.?[0-9]*$'; then + inner="<failure message=\"Performance Regressed\" type=\"WARNING\">\ + Performance regressed by $estimate in $test\ + </failure>" + worse=$((worse+1)) + fi testcases="$testcases<testcase id=\"$(echo "$test" | cut -d'/' -f 6)\" name=\"$(echo "$test" | cut -d'/' -f 6)\">$inner</testcase>" tests=$((tests+1)) done -- GitLab