Commit d0f3763f authored by Ryan Hunt's avatar Ryan Hunt

Do some formatting

parent 5215c801
......@@ -2,16 +2,18 @@
Thanks for wanting to contribute!
If you want help or mentorship, please file a Github issue or comment on an existing one and I'll be sure to provide guidance to the best of my ability.
If you want help or mentorship, please file a Github issue and I'll be sure to provide guidance to the best of my ability.
Otherwise be sure to check out `ARCHITECTURE.md` for an overview on the internals.
## Filing a pull request
Check out [Servo's Github workflow](https://github.com/servo/servo/wiki/Github-workflow) for an overview on creating a pull request. Don't worry about requesting code review, as there is nothing formally setup for this repository. I review each pull request as soon as I can.
Check out [Servo's Github workflow](https://github.com/servo/servo/wiki/Github-workflow) for an overview on creating a pull request.
There is continuous integration setup for `cbindgen` using `travis`. It will automatically run `./test.py` which tests `cbindgen` on a series of rust files in `tests/rust/` and verifes that the output compiles using `gcc` or `g++`.
Don't worry about requesting code review, as there is nothing formally setup for this repository. I try and review each pull request as soon as I can.
Please run `./test.py` before filing a pull request to be sure that all tests pass. Bonus points if you write a new test for your pull request!
There is continuous integration setup for `cbindgen` using [travis](https://travis-ci.org/). It automatically runs `./test.py` which runs `cbindgen` against a series of rust files from `tests/rust/` and checks that the output compiles using `gcc` or `g++`.
The outputed headers for each test are committed and verified as being up to date in each pull request, so be sure to run `./test.py`.
Please run `./test.py` before filing a pull request to be sure that all tests pass. This will also update the test expectations.
Bonus points if you write a new test for your pull request!
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment