redox-os issueshttps://gitlab.redox-os.org/groups/redox-os/-/issues2018-06-13T19:39:50Zhttps://gitlab.redox-os.org/redox-os/ralloc/-/issues/40Update the website link2018-06-13T19:39:50ZJeremy SollerUpdate the website link*Created by: lu-zero*
It should point to https://doc.redox-os.org/std/ralloc/*Created by: lu-zero*
It should point to https://doc.redox-os.org/std/ralloc/https://gitlab.redox-os.org/redox-os/conc/-/issues/1Feature: documentation for forward progress guarantees2018-06-13T19:39:50ZJeremy SollerFeature: documentation for forward progress guarantees*Created by: dbkaplun*
Hello,
Thanks for making this crate! Would it be possible to add information to the documentation for each method describing its forward progress guarantee (obstruction-free, lock-free, wait-free)?
Thanks fo...*Created by: dbkaplun*
Hello,
Thanks for making this crate! Would it be possible to add information to the documentation for each method describing its forward progress guarantee (obstruction-free, lock-free, wait-free)?
Thanks for considering!
https://gitlab.redox-os.org/redox-os/arg-parser/-/issues/3Test failure: `tests::settings`2018-06-13T19:39:50ZJeremy SollerTest failure: `tests::settings`*Created by: xTibor*
This test fails at the moment due to some incorrect behaviour of the `add_setting_default` method. I noticed this problem via the [`dd`](https://github.com/redox-os/coreutils/blob/923f48fac93b79e1ea637e585a0717e19f5...*Created by: xTibor*
This test fails at the moment due to some incorrect behaviour of the `add_setting_default` method. I noticed this problem via the [`dd`](https://github.com/redox-os/coreutils/blob/923f48fac93b79e1ea637e585a0717e19f565761/src/bin/dd.rs) command, it throws panicks when the `bs` or `count` arguments are omitted.
**Log**:
```
failures:
---- tests::settings stdout ----
thread 'tests::settings' panicked at 'assertion failed: parser.get_setting("of") == Some(String::from("foo"))', src/lib.rs:516:8
```
https://gitlab.redox-os.org/redox-os/arg-parser/-/issues/7Add docs to docs.redox-os.org2018-06-13T19:39:50ZSamwiseFilmoremggmugginsmc@gmail.comAdd docs to docs.redox-os.orgThis would be nice. I'd like to see more of redox's crates up there, it will likely be very good for contributers getting involved.This would be nice. I'd like to see more of redox's crates up there, it will likely be very good for contributers getting involved.https://gitlab.redox-os.org/redox-os/arg-parser/-/issues/5eprintln2018-06-13T19:39:50ZSamwiseFilmoremggmugginsmc@gmail.comeprintlnThis is a bit of a follow-up to https://github.com/redox-os/coreutils/issues/186, I got an idea while reviewing code for error handling in userutils and redox_users:
This is a pattern that we see an AWFUL lot of:
```Rust
let user = ge...This is a bit of a follow-up to https://github.com/redox-os/coreutils/issues/186, I got an idea while reviewing code for error handling in userutils and redox_users:
This is a pattern that we see an AWFUL lot of:
```Rust
let user = get_user_by_id(euid).unwrap_or_else(|err| {
eprintln!("whoami: {}", err);
exit(1);
});
```
A situation where an error occurs and the program prints it's name, followed by a colon, followed by the error to stderr and then exits (with a nonzero exit code).
Most (if not all) of these programs have an instance of parser in scope for the entirety of the main function, and this pattern is most often seen as a part of the main function. `ArgParser` already has access to the correct prefix for the format error, so I wonder if we could do one of the following:
1) Create a method on `ArgParser` (or a function that takes `ArgParser`, or something similar) that effectively does this given a `failure::Error`
2) Create a macro that somehow accomplishes this, given an instance of `ArgParser` and an error.
I have no experience or knowledge of writing macros, but it's a thought.https://gitlab.redox-os.org/redox-os/website/-/issues/173Translations update2018-06-13T19:39:50ZJeremy SollerTranslations update*Created by: nickik*
The new community.<lang>.md files need to be translated.
Also the titles in config.toml.
*Created by: nickik*
The new community.<lang>.md files need to be translated.
Also the titles in config.toml.
https://gitlab.redox-os.org/redox-os/website/-/issues/148Display Reddit comment link at bottom of articles2018-06-13T19:39:50ZIan Douglas ScottDisplay Reddit comment link at bottom of articlesSince this uses a static site generator, javascript is probably the best way to do this. It could test if the article has been linked to on r/redox, and if so display a link.Since this uses a static site generator, javascript is probably the best way to do this. It could test if the article has been linked to on r/redox, and if so display a link.https://gitlab.redox-os.org/redox-os/extrautils/-/issues/40Piping to less and mdless splits input2018-06-13T19:39:50ZJeremy SollerPiping to less and mdless splits input*Created by: moore3071*
## Steps to reproduce
run `cat /filesystem.toml | less`
## Expected behaviour
The content of `/filesystem.toml` can be viewed through the pager less with identical functionality to `less /filesystem.toml`.
##...*Created by: moore3071*
## Steps to reproduce
run `cat /filesystem.toml | less`
## Expected behaviour
The content of `/filesystem.toml` can be viewed through the pager less with identical functionality to `less /filesystem.toml`.
## Actual behaviour
The less interface is interlaced with the terminal prompt. input is accepted from the prompt for one input character followed by less accepting the next input and so on. Upon exiting less by pressing `q` the terminal goes blank until further input which then displays the prompt with whatever input it read while less was running.https://gitlab.redox-os.org/redox-os/extrautils/-/issues/38Is "extra" crate relevant?2018-06-13T19:39:50ZJeremy SollerIs "extra" crate relevant?*Created by: bmusin*
It seems, that "extra" crate hasn't been build successfully since June of last year.
Should one use it or roll out his own solutions instead?
Documentation is missing too.*Created by: bmusin*
It seems, that "extra" crate hasn't been build successfully since June of last year.
Should one use it or roll out his own solutions instead?
Documentation is missing too.https://gitlab.redox-os.org/redox-os/extrautils/-/issues/35removing #![deny(warnings)]2018-06-13T19:39:51ZJeremy Sollerremoving #![deny(warnings)]*Created by: bmusin*
Hi.
What do you think about removing #![deny(warnings)] directive?
It may cause failure building code in the future, when some code would be treated as warnings.
Or is it policy?
https://github.com/rust-unof...*Created by: bmusin*
Hi.
What do you think about removing #![deny(warnings)] directive?
It may cause failure building code in the future, when some code would be treated as warnings.
Or is it policy?
https://github.com/rust-unofficial/patterns/blob/master/anti_patterns/deny-warnings.mdhttps://gitlab.redox-os.org/redox-os/relibc/-/issues/44Create sys/types.h based on platform::types2018-06-13T19:39:51ZDan RobertsonCreate sys/types.h based on platform::typesAt the moment `sys/types.h` is created by [include/sys/types.h](https://github.com/redox-os/relibc/blob/master/include/sys/types.h). Instead `sys/types.h` should be autogenerated based on the contents of `platform::types`. Then any types...At the moment `sys/types.h` is created by [include/sys/types.h](https://github.com/redox-os/relibc/blob/master/include/sys/types.h). Instead `sys/types.h` should be autogenerated based on the contents of `platform::types`. Then any types that need to be defined in C can be defined in a `include/bits/sys/type.h`.
I don't think it is possible to generate a header based on a single module with `cbindgen`. We may need to break out `platform::types` into a separate crate in the `src` directory.https://gitlab.redox-os.org/redox-os/extrautils/-/issues/10-P grep option2018-06-13T19:39:51ZJeremy Soller-P grep option*Created by: Mouvedia*
http://www.gnu.org/software/grep/manual/grep.html#index-_002dP
long form: `--perl-regexp`
*Created by: Mouvedia*
http://www.gnu.org/software/grep/manual/grep.html#index-_002dP
long form: `--perl-regexp`
https://gitlab.redox-os.org/redox-os/tfs/-/issues/81add efi driver support2018-06-13T19:39:51ZJeremy Solleradd efi driver support*Created by: fneddy*
It would be cool to have a _tfs.efi_ (tfs efi filesystem driver).
This would allow all other efi bootloader (grub, refind, systemd-boot, ...) to read tfs and potentially to boot redox.
maybe this should not be...*Created by: fneddy*
It would be cool to have a _tfs.efi_ (tfs efi filesystem driver).
This would allow all other efi bootloader (grub, refind, systemd-boot, ...) to read tfs and potentially to boot redox.
maybe this should not be part o this project but separated in another crate?
https://gitlab.redox-os.org/redox-os/netutils/-/issues/29wget doesn't recognize an url when it contains parameters2018-06-13T19:39:51ZJeremy Sollerwget doesn't recognize an url when it contains parameters*Created by: Nickforall*
I've done some tests, and it seems to fail whenever the url contains an `=` character. It's okay with `?`.
![screenshot from 2017-12-16 16-13-47](https://user-images.githubusercontent.com/4987698/34071775-1d7...*Created by: Nickforall*
I've done some tests, and it seems to fail whenever the url contains an `=` character. It's okay with `?`.
![screenshot from 2017-12-16 16-13-47](https://user-images.githubusercontent.com/4987698/34071775-1d77b1ee-e27c-11e7-830b-7f48d365de73.png)
https://gitlab.redox-os.org/redox-os/orbclient/-/issues/34`Renderer::rect()` draws pixels on the screen, even when the rect is fully ou...2018-06-13T19:39:51ZJeremy Soller`Renderer::rect()` draws pixels on the screen, even when the rect is fully outside the window.*Created by: ca1ek*
```rust
let mut window = orbclient::Window::new(-1, -1, 640, 480, "kek").unwrap();
window.set(Color::rgb(255, 255, 255));
window.rect(700, 20, 10, 10, Color::rgb(12,34,56));
window.sync();
th...*Created by: ca1ek*
```rust
let mut window = orbclient::Window::new(-1, -1, 640, 480, "kek").unwrap();
window.set(Color::rgb(255, 255, 255));
window.rect(700, 20, 10, 10, Color::rgb(12,34,56));
window.sync();
thread::sleep(time::Duration::from_secs(5));
```
Even though that the rect is at `x=700`, and the window has `w=640` you still can see a small line of pixels at the edge of the window.
[Image](http://i.imgur.com/WecHxr2.png)
https://gitlab.redox-os.org/redox-os/orbclient/-/issues/28Improper alpha value handling.2018-06-13T19:39:51ZJeremy SollerImproper alpha value handling.*Created by: ca1ek*
I got code like this
```rust
let Wallpaper { mut image, data } = wallpaper;
let mut mask = Image::from_color(160, 90, Color::rgb(255, 255, 255));
mask.rounded_rect(2, 2, 156, 86, 5, true...*Created by: ca1ek*
I got code like this
```rust
let Wallpaper { mut image, data } = wallpaper;
let mut mask = Image::from_color(160, 90, Color::rgb(255, 255, 255));
mask.rounded_rect(2, 2, 156, 86, 5, true, Color::rgba(0, 0, 0, 0)); // <-- is zero
image.image(0, 0, 160, 90, mask.data());
```
this won't change the mask at all because the alpha value is 0.
If I change it to
```rust
let Wallpaper { mut image, data } = wallpaper;
let mut mask = Image::from_color(160, 90, Color::rgb(255, 255, 255));
mask.rounded_rect(2, 2, 156, 86, 5, true, Color::rgba(0, 0, 0, 1)); // <-- now is one
image.image(0, 0, 160, 90, mask.data());
```
the `rounded_rectangle` call won't get ignored, but then `image` won't interpolate it with previous values on the image, which results in a slightly dark rounded rectangle instead of a white border around the wallpaper preview.
http://i.imgur.com/u7SaTDm.png
Alpha value handling should be made the same across all renderer functions, or not to slow down existing applications that don't require correct alpha handling, a new `AlphaRenderer` implementation
should be made.https://gitlab.redox-os.org/redox-os/relibc/-/issues/94Make the root build.rs smarter2018-06-13T19:39:51ZDan RobertsonMake the root build.rs smarterCurrently we create a crate for each header we want to output. As a result there is quite a bit of super generic work that occurs when a new header is created. We could create a build script for the root crate that functions more like th...Currently we create a crate for each header we want to output. As a result there is quite a bit of super generic work that occurs when a new header is created. We could create a build script for the root crate that functions more like the [`main` in cbindgen](https://github.com/eqrion/cbindgen/blob/master/src/main.rs) that is used for their test script. This would allow us to use modules or crates (in the rare case that wee need it) to build a new header.
### Example
We currently have the following
```
├── src
│ ├── simple
│ │ ├── Cargo.toml
│ │ ├── cbindgen.toml
│ │ ├── build.rs
│ │ └── src
│ │ └── lib.rs
│ └── complex
│ ├── Cargo.toml
│ ├── cbindgen.toml
│ ├── build.rs
│ └── src
│ ├── lib.rs
│ └── other-stuff.rs
...
```
If we make the root `build.rs` a bit smarter. AFAIK we could have something like the following.
```
├── src
│ ├── simple.rs
│ ├── other.rs
│ ├── other.toml
│ └── complex
│ ├── Cargo.toml
│ ├── cbindgen.toml
│ └── src
│ ├── lib.rs
│ └── other-stuff.rs
...
```
Where `other` needs it's own config and `simple` can just use the default config.https://gitlab.redox-os.org/redox-os/userutils/-/issues/34User enumeration at login2018-06-13T19:39:51ZJeremy SollerUser enumeration at login*Created by: xTibor*
The `login` program is vulnerable to user enumeration. It only asks for a password and does a timeout when the specified user account exists, thus allowing malicious actors to brute force the possible users at a rat...*Created by: xTibor*
The `login` program is vulnerable to user enumeration. It only asks for a password and does a timeout when the specified user account exists, thus allowing malicious actors to brute force the possible users at a rate of hundreds of usernames per second. (when login asks for a password = valid user on the system).
**Demo:**
https://www.youtube.com/watch?v=7XfipgWmpxM
**Possible fix:**
Ask for a password and do a timeout even the specified user doesn't exist.https://gitlab.redox-os.org/redox-os/relibc/-/issues/25Generate docs2018-06-13T19:39:51ZJeremy SollerGenerate docsGenerate rust documentation and put it on a github.io siteGenerate rust documentation and put it on a github.io sitehttps://gitlab.redox-os.org/redox-os/userutils/-/issues/18Compile issues with Cargo and getty2018-06-13T19:39:51ZSamwiseFilmoremggmugginsmc@gmail.comCompile issues with Cargo and gettyI get a lot of mismatched type errors with `getty` when I compile the repo with `cargo build`. When userutils is built as a part of cookbook, then it builds and deploys fine. All the errors are either "expected usize, found i32" or "expe...I get a lot of mismatched type errors with `getty` when I compile the repo with `cargo build`. When userutils is built as a part of cookbook, then it builds and deploys fine. All the errors are either "expected usize, found i32" or "expected i32, found usize". Any thoughts/ideas?