redox-os issueshttps://gitlab.redox-os.org/groups/redox-os/-/issues2022-11-19T07:45:37Zhttps://gitlab.redox-os.org/redox-os/ion/-/issues/1016Panic on `&&` and `||` operators2022-11-19T07:45:37ZAurélien CléracPanic on `&&` and `||` operatorsbug: Logical operators `&&` and `||` may panic if not followed by a command.
expect: syntax error.
related: none.
test case#1
code: input
```
ls &&||
```
test case#2
code: input
```
ls &&;
```
actual: output
```
[...]
thread 'main' ...bug: Logical operators `&&` and `||` may panic if not followed by a command.
expect: syntax error.
related: none.
test case#1
code: input
```
ls &&||
```
test case#2
code: input
```
ls &&;
```
actual: output
```
[...]
thread 'main' panicked at 'begin <= end (6 <= 5) when slicing `ls &&||`', src/lib/parser/statement/splitter.rs:55:35
stack backtrace:
[...]
4: ion_shell::parser::statement::splitter::StatementSplitter::get_statement
5: <ion_shell::parser::statement::splitter::StatementSplitter as core::iter::traits::iterator::Iterator>::next
6: ion_shell::shell::flow::<impl ion_shell::shell::Shell>::on_command
7: ion::binary::InteractiveShell::exec
8: ion::binary::InteractiveShell::execute_interactive
9: ion::main
Abandon (core dumped)
```
expect: output
```
ion: syntax error: expected command, but found `||`
```
version: ion 1.0.0-alpha (x86_64-unknown-linux-gnu), rev 814ed5a887ad88b98b142af28f653ff4f249de6c
interaction: none
---
According to backtrace, the bug came from src/lib/parser/statement/splitter.rs:55:35 which is :
```
fn get_statement(&self, start: usize, end: usize) -> StatementVariant<'a> {
if self.logical == LogicalOp::And {
StatementVariant::And(self.data[start + 1..end].trim())
^^^^^^^^^^^^^^^
} else if self.logical == LogicalOp::Or {
StatementVariant::Or(self.data[start + 1..end].trim())
} else {
StatementVariant::Default(self.data[start..end].trim())
}
}
```
called by src/lib/parser/statement/splitter.rs:160:42 and src/lib/parser/statement/splitter.rs:171:42 :
```
b';' if self.paren_level == 0 => {
let statement = self.get_statement(start, i);
^^^^^^^^^^^^^^^^^^^^^^^
self.logical = LogicalOp::None;
self.read = i + 1;
return match error {
Some(error) => Some(Err(error)),
None => Some(Ok(statement)),
};
}
b'&' | b'|' if self.paren_level == 0 && last == Some(character) => {
// Detecting if there is a 2nd `&` character
let statement = self.get_statement(start, i - 1);
^^^^^^^^^^^^^^^^^^^^^^^^^^^
self.logical = if character == b'&' { LogicalOp::And } else { LogicalOp::Or };
self.read = i + 1;
return match error {
Some(error) => Some(Err(error)),
None => Some(Ok(statement)),
};
}
_ => {}
}
last = Some(character);
}
```
On both calls, _get_statement_ try to slice the command line with incorrect index.
If we pick test case#1, `ls &&||`, _start_ equals 5 but is added 1 and _i_ equals 6 minus 1 which gives `&"ls &&||"[6..5]`.
As I understand, syntax is checked along the command execution so a syntax error can be raised while Ion
has already executed N statements from a given command line. Ion could check if `self.logical` is already
set to _And_ or _Or_ instead of _None_ while performing `&&`, `||` or `;` but it does not look quite right
and did not pass cargo test(infinity loop) when I tried to implement it.
I'm pretty new to Rust and it feels a bit overwhelming for now to find an elegant solution which does fit well
with Ion's codebase.
Thanks in advance for your help,
Aurélienhttps://gitlab.redox-os.org/redox-os/redox/-/issues/1363Can't use apps downloaded with pkg2022-09-23T20:33:33ZNoé LopezCan't use apps downloaded with pkg<!-- Thank you for taking the time to submit an issue! By following these comments and filling out the sections below, you can help the developers get the necessary information to fix your issue. Please provide a single issue per report....<!-- Thank you for taking the time to submit an issue! By following these comments and filling out the sections below, you can help the developers get the necessary information to fix your issue. Please provide a single issue per report. You can also preview this report before submitting it. Feel free to modify/remove sections to fit the nature of your issue. -->
<!-- Please search to check that your issue has not been created already. By preventing duplicate issues, you can help keep the repository organized. If your current issue has already been created and is still unresolved, you can contribute by commenting there. -->
<!-- Replace the empty checkbox [ ] below with a checked one [x] if you have already searched for your issue. -->
- [x] I agree that I have searched opened and closed issues to prevent duplicates.
--------------------
## Description
<!-- Briefly summarize/describe the issue that you are experiencing below. -->
I can't launch applications that I downloaded with pkg (tested sodium and rusthello, same error)
## Environment info
<!-- To understand where your issue originates, please include some relevant information about your environment. -->
<!-- If you are using a pre-built release of Redox, please specify the release version below. -->
- Redox OS Release:
0.6.0
<!-- Depending on your issue, additional information about your environment (network config, package versions, dependencies, etc.) can also help. You can list that below. -->
Running on qemu kvm using the command listed in the book :
```
qemu-system-x86_64 -serial mon:stdio -d cpu_reset -d guest_errors -smp 4 -m 1024 -s -machine q35 -device ich9-intel-hda -device hda-duplex -net nic,model=e1000 -net user -device nec-usb-xhci,id=xhci -device usb-tablet,bus=xhci.0 -enable-kvm -cpu host -drive file=harddrive.bin,format=raw
```
## Steps to reproduce
<!-- If possible, please list the steps to reproduce ("trigger") your issue below. Being detailed definitely helps speed up bug fixes. -->
1. Download a package (`pkg install sodium`)
2. Open it (`$ sodium`)
3. Doesn't open
## Behavior
<!-- It may seem obvious to know what to expect, but isolating the behavior from everything else simplifies the development process. Remember to provide a single issue in this report. You can use the References section below to link your issues together. -->
<!-- Describe the behavior you expect your steps should yield (i.e., correct behavior). -->
- **Expected behavior**:
The app opens
<!-- Describe the behavior you observed when running your steps (i.e., buggy behavior). -->
- **Actual behavior**:
I get the following error in the kernel logs:
```
Invalid opcode fault
RFLAG: 0000000000010206
CS: 0000000000000023
RIP: 000000000044F96D
RAX: 0000000000000000
RCX: 000000000045D9E3
RDX: 0000000000000001
RDI: 0000000000000002
RSI: 000000000056FCA4
R8: 00000180000FFBD0
R9: 0000000001010000
R10: FFFFFFFFFFFFFFFF
R11: 0000000000000202
RBX: 00000180000FFE30
RBP: 0000000000000000
R12: 0000000000000000
R13: 0000000000000000
R14: 00000180000FFE30
R15: 0000000000000000
FS: 0000000000000033
TRACE: FFFFFF00004B72C8
FFFFFF00004B72C8: FFFF8000001389B8
FFFF8000001388C0+00F8
__interrupt_invalid_opcode
FFFFFF00004B7348: FFFF8000001011CF
FFFF8000001011A4+002B
invalid_opcode
0000000000000000: GUARD PAGE
kernel:INFO -- SIGNAL 4, CPU 3, PID ContextId(167)
kernel:INFO -- NAME file:/ui/bin/sodium
Ok("file:/ui/bin/orbterm") using deprecated funmap(...) call
```
And this one in the terminal:
```
panicked in ld.so: failed to open handle for process registers: expect failed for Result with err: No such device
ion: pipeline execution error: process (161) ended by signall SIGILL
```https://gitlab.redox-os.org/redox-os/ion/-/issues/1014README documentation links broken2022-09-17T14:22:20ZzraktvorREADME documentation links brokenBoth links to documentation in the README point to https://doc.redox-os.org/ion-manual/html, which gives an http error 404.
The correct link seems to be https://doc.redox-os.org/ion-manual.Both links to documentation in the README point to https://doc.redox-os.org/ion-manual/html, which gives an http error 404.
The correct link seems to be https://doc.redox-os.org/ion-manual.https://gitlab.redox-os.org/redox-os/redox/-/issues/1362Browser Resizing doesn't work as intended2023-10-27T13:50:46ZKtoksBrowser Resizing doesn't work as intended<!-- Thank you for taking the time to submit an issue! By following these comments and filling out the sections below, you can help the developers get the necessary information to fix your issue. Please provide a single issue per report....<!-- Thank you for taking the time to submit an issue! By following these comments and filling out the sections below, you can help the developers get the necessary information to fix your issue. Please provide a single issue per report. You can also preview this report before submitting it. Feel free to modify/remove sections to fit the nature of your issue. -->
<!-- Please search to check that your issue has not been created already. By preventing duplicate issues, you can help keep the repository organized. If your current issue has already been created and is still unresolved, you can contribute by commenting there. -->
<!-- Replace the empty checkbox [ ] below with a checked one [x] if you have already searched for your issue. -->
- [x] I agree that I have searched opened and closed issues to prevent duplicates.
--------------------
## Description
<!-- Briefly summarize/describe the issue that you are experiencing below. -->
When the user attempts to resize the browser horizontally or diagonally to the left, the browser drags in the direction the user is attempting to expand or contract the window size, vertical and right changes aren't registered, resizing does not work, and just places the browser at the top left of the screen
Upon further investigation, resizing in any way freezes the browser, and prevents the user from closing it. See second log for the second window I opened and attempted to resize vertically.
The third log is for maximizing the window- which also froze the browser.
## Environment info
<!-- To understand where your issue originates, please include some relevant information about your environment. -->
<!-- If you are using a pre-built release of Redox, please specify the release version below. -->
- Redox OS Release:
0.7.0
<!-- If you have built Redox OS yourself, please provide the following information: -->
- Operating system:
Pop! OS
- `uname -a`:
`Linux pop-os 5.18.10-76051810-generic #202207071639~1659108431~22.04~c9172fb SMP PREEMPT_DYNAMIC Fri J x86_64 x86_64 x86_64 GNU/Linux`
- `rustc -V`:
`rustc 1.62.1 (e092d0b6b 2022-07-16)`
- `git rev-parse HEAD`:
`git rev-parse HEAD`
<!-- Depending on your issue, additional information about your environment (network config, package versions, dependencies, etc.) can also help. You can list that below. -->
1080 16 x 9 resolution
## Steps to reproduce
<!-- If possible, please list the steps to reproduce ("trigger") your issue below. Being detailed definitely helps speed up bug fixes. -->
1. Open the browser
2. resize left moves the browser
3. resize vertical or right does nothing
## Behavior
<!-- It may seem obvious to know what to expect, but isolating the behavior from everything else simplifies the development process. Remember to provide a single issue in this report. You can use the References section below to link your issues together. -->
<!-- Describe the behavior you expect your steps should yield (i.e., correct behavior). -->
- **Expected behavior**:
The browser should resize in the direction the edge of the window is dragged, and when the maximize button is pressed, the browser should fill the screen
<!-- Describe the behavior you observed when running your steps (i.e., buggy behavior). -->
- **Actual behavior**:
left resize attempt causes dragging, right and vertical attempt fails to resize, the maximize button moves the browser to the top left of the screen without resizing, any form of resizing freezes the browser
<!-- **Logs?** Posting a log can help developers find your particular issue more easily. Please wrap your code in code blocks using triple back-ticks ``` to increase readability. -->
```
thread 'main' panicked at 'orbclient: failed to unmap memory in resize: Invalid argument', /home/papapop/.cargo/registry/src/github.com-1ecc6299db9ec823/orbclient-0.3.32/src/sys/orbital.rs:260:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
launcher: /ui/bin/file_manager (267) exited with exit status: 101
launcher: reaping zombie 268: exit status: 0
launcher: reaping zombie 269: exit status: 0
launcher: reaping zombie 270: exit status: 0
launcher: reaping zombie 271: exit status: 0
launcher: reaping zombie 272: exit status: 0
launcher: reaping zombie 273: exit status: 0
launcher: reaping zombie 274: exit status: 0
launcher: reaping zombie 275: exit status: 0
launcher: reaping zombie 276: exit status: 0
launcher: reaping zombie 277: exit status: 0
launcher: reaping zombie 278: exit status: 0
launcher: reaping zombie 279: exit status: 0
launcher: reaping zombie 280: exit status: 0
launcher: reaping zombie 281: exit status: 0
launcher: reaping zombie 282: exit status: 0
pte_osSemaphoreCancellablePend 0xa30c0 0x0
WARNING: You are using the SDL orbital video driver!
kernel::scheme::user:WARN -- Unaligned map size for context Some("/bin/netsurf-fb")
Setting mode 800x600@32
setsockopt(12, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(13, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(14, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(15, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(16, 6, 1, 0x7ffffffff4fc, 4) - unknown option
redoxfs: funmap 0xF000, 8192
thread '<unnamed>' panicked at 'orbclient: failed to unmap memory in resize: Invalid argument', /home/papapop/.cargo/registry/src/github.com-1ecc6299db9ec823/orbclient-0.3.29/src/sys/orbital.rs:260:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5
abort() called
Invalid opcode fault
RFLAG: 0000000000010202
CS: 0000000000000033
RIP: 00000000009a07ee
RSP: 00007ffffffff610
SS: 000000000000002b
FSBASE 0000000000004000
GSBASE 0000000000000000
KGSBASE fffffd8000000050
RAX: 0000000000000000
RCX: 0000000000a1bb63
RDX: 000000000000000f
RDI: 0000000000000002
RSI: 0000000000dc00a7
R8: 00007ffffffff520
R9: 0000000000000001
R10: 00007ffffffff528
R11: 0000000000000202
RBX: 0000000000d71ec0
RBP: 00000000010efa88
R12: 0000000000000001
R13: 00007ffffffff8e8
R14: 0000000000000000
R15: 00000000010a1868
TRACE: FFFFFE80018C52C0
FFFFFE80018C52C0: FFFFFF000008A0C7
FFFFFF0000089F90+0137
kernel::arch::x86_64::interrupt::exception::invalid_opcode::inner
FFFFFE80018C5350: FFFFFF0000087F2D
FFFFFF0000087F00+002D
kernel::arch::x86_64::interrupt::exception::invalid_opcode
00000000010EFA88: EMPTY RETURN
kernel:INFO -- SIGNAL 4, CPU 0, PID ContextId(283)
kernel:INFO -- NAME /bin/netsurf-fb
launcher: /bin/netsurf-fb (283) exited with signal: 4
pte_osSemaphoreCancellablePend 0xa30c0 0x0
WARNING: You are using the SDL orbital video driver!
kernel::scheme::user:WARN -- Unaligned map size for context Some("/bin/netsurf-fb")
Setting mode 800x600@32
setsockopt(12, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(13, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(14, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(15, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(16, 6, 1, 0x7ffffffff4fc, 4) - unknown option
redoxfs: funmap 0xF000, 8192
launcher: /bin/netsurf-fb (285) exited with exit status: 0
smolnetd::scheme: poll error: dropped by socket
```
Second resize log:
```
smolnetd::scheme: poll error: dropped by socket
pte_osSemaphoreCancellablePend 0xa30c0 0x0
WARNING: You are using the SDL orbital video driver!
kernel::scheme::user:WARN -- Unaligned map size for context Some("/bin/netsurf-fb")
Setting mode 800x600@32
setsockopt(12, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(13, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(14, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(15, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(16, 6, 1, 0x7ffffffff4fc, 4) - unknown option
redoxfs: funmap 0xF000, 8192
thread '<unnamed>' panicked at 'orbclient: failed to unmap memory in resize: Invalid argument', /home/papapop/.cargo/registry/src/github.com-1ecc6299db9ec823/orbclient-0.3.29/src/sys/orbital.rs:260:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5
abort() called
Invalid opcode fault
RFLAG: 0000000000010202
CS: 0000000000000033
RIP: 00000000009a07ee
RSP: 00007ffffffff610
SS: 000000000000002b
FSBASE 0000000000004000
GSBASE 0000000000000000
KGSBASE fffffd8000000050
RAX: 0000000000000000
RCX: 0000000000a1bb63
RDX: 000000000000000f
RDI: 0000000000000002
RSI: 0000000000dc00a7
R8: 00007ffffffff520
R9: 0000000000000001
R10: 00007ffffffff528
R11: 0000000000000202
RBX: 0000000000d71ec0
RBP: 00000000010efa88
R12: 0000000000000001
R13: 00007ffffffff8e8
R14: 0000000000000000
R15: 00000000010a1868
TRACE: FFFFFE80019232C0
FFFFFE80019232C0: FFFFFF000008A0C7
FFFFFF0000089F90+0137
kernel::arch::x86_64::interrupt::exception::invalid_opcode::inner
FFFFFE8001923350: FFFFFF0000087F2D
FFFFFF0000087F00+002D
kernel::arch::x86_64::interrupt::exception::invalid_opcode
00000000010EFA88: EMPTY RETURN
kernel:INFO -- SIGNAL 4, CPU 0, PID ContextId(287)
kernel:INFO -- NAME /bin/netsurf-fb
launcher: /bin/netsurf-fb (287) exited with signal: 4
```
Maximize log:
```
pte_osSemaphoreCancellablePend 0xa30c0 0x0
WARNING: You are using the SDL orbital video driver!
kernel::scheme::user:WARN -- Unaligned map size for context Some("/bin/netsurf-fb")
Setting mode 800x600@32
setsockopt(12, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(13, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(14, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(15, 6, 1, 0x7ffffffff4fc, 4) - unknown option
setsockopt(16, 6, 1, 0x7ffffffff4fc, 4) - unknown option
redoxfs: funmap 0xF000, 8192
thread '<unnamed>' panicked at 'orbclient: failed to unmap memory in resize: Invalid argument', /home/papapop/.cargo/registry/src/github.com-1ecc6299db9ec823/orbclient-0.3.29/src/sys/orbital.rs:260:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5
abort() called
Invalid opcode fault
RFLAG: 0000000000010202
CS: 0000000000000033
RIP: 00000000009a07ee
RSP: 00007ffffffff610
SS: 000000000000002b
FSBASE 0000000000004000
GSBASE 0000000000000000
KGSBASE fffffd8000000050
RAX: 0000000000000000
RCX: 0000000000a1bb63
RDX: 000000000000000f
RDI: 0000000000000002
RSI: 0000000000dc00a7
R8: 00007ffffffff520
R9: 0000000000000001
R10: 00007ffffffff528
R11: 0000000000000202
RBX: 0000000000d71ec0
RBP: 00000000010efa88
R12: 0000000000000001
R13: 00007ffffffff8e8
R14: 0000000000000000
R15: 00000000010a1868
TRACE: FFFFFE800195A2C0
FFFFFE800195A2C0: FFFFFF000008A0C7
FFFFFF0000089F90+0137
kernel::arch::x86_64::interrupt::exception::invalid_opcode::inner
FFFFFE800195A350: FFFFFF0000087F2D
FFFFFF0000087F00+002D
kernel::arch::x86_64::interrupt::exception::invalid_opcode
00000000010EFA88: EMPTY RETURN
kernel:INFO -- SIGNAL 4, CPU 0, PID ContextId(289)
kernel:INFO -- NAME /bin/netsurf-fb
launcher: /bin/netsurf-fb (289) exited with signal: 4
```
<!-- **Solution?** Have a solution in mind? Propose your solution below. -->
- **Proposed solution**:
<!-- **Screenshots?** Make it easier to get your point across with screenshots. You can drag & drop or paste your images below. -->
## Optional references
<!-- If you have found issues or pull requests that are related to or blocking this issue, please link them below. See https://help.github.com/articles/autolinked-references-and-urls/ for more options. You can also link related code snippets by providing the permalink. See https://help.github.com/articles/creating-a-permanent-link-to-a-code-snippet/ for more information. -->
Related to:
- #1360
## Optional extras
<!-- If you have other relevant information not found in other sections, you can include it below. -->
<!-- **Code?** Awesome! You can also create a pull request with a reference to this issue. -->
<!-- **Files?** Attach your relevant files by dragging & dropping or pasting them below. -->
<!-- You also can preview your report before submitting it. Thanks for contributing to Redox! -->https://gitlab.redox-os.org/redox-os/redox/-/issues/1360Resize Display Horizontally Crashes Current Window2023-10-27T13:49:36ZKtoksResize Display Horizontally Crashes Current Window<!-- Thank you for taking the time to submit an issue! By following these comments and filling out the sections below, you can help the developers get the necessary information to fix your issue. Please provide a single issue per report....<!-- Thank you for taking the time to submit an issue! By following these comments and filling out the sections below, you can help the developers get the necessary information to fix your issue. Please provide a single issue per report. You can also preview this report before submitting it. Feel free to modify/remove sections to fit the nature of your issue. -->
<!-- Please search to check that your issue has not been created already. By preventing duplicate issues, you can help keep the repository organized. If your current issue has already been created and is still unresolved, you can contribute by commenting there. -->
<!-- Replace the empty checkbox [ ] below with a checked one [x] if you have already searched for your issue. -->
- [x] I agree that I have searched opened and closed issues to prevent duplicates.
--------------------
## Description
<!-- Briefly summarize/describe the issue that you are experiencing below. -->
Upon opening nearly any app and attempting to resize it horizontally or diagonally, or hitting the maximize button in full screen, the app will crash and close.
## Environment info
<!-- To understand where your issue originates, please include some relevant information about your environment. -->
<!-- If you are using a pre-built release of Redox, please specify the release version below. -->
- Redox OS Release:
0.7.0
<!-- If you have built Redox OS yourself, please provide the following information: -->
- Operating system:
Pop! OS
- `uname -a`:
`Linux pop-os 5.18.10-76051810-generic #202207071639~1659108431~22.04~c9172fb SMP PREEMPT_DYNAMIC Fri J x86_64 x86_64 x86_64 GNU/Linux`
- `rustc -V`:
`rustc 1.62.1 (e092d0b6b 2022-07-16)`
- `git rev-parse HEAD`:
`git rev-parse HEAD`
<!-- Depending on your issue, additional information about your environment (network config, package versions, dependencies, etc.) can also help. You can list that below. -->
1080 16 x 9 resolution
## Steps to reproduce
<!-- If possible, please list the steps to reproduce ("trigger") your issue below. Being detailed definitely helps speed up bug fixes. -->
1. Log in
2. Open an app with resize-ability (Except for the browser, see #1362)
3. Resize horizontally, or diagonally, or returning from full screen with 'maximize' button
## Behavior
<!-- It may seem obvious to know what to expect, but isolating the behavior from everything else simplifies the development process. Remember to provide a single issue in this report. You can use the References section below to link your issues together. -->
<!-- Describe the behavior you expect your steps should yield (i.e., correct behavior). -->
- **Expected behavior**:
App window resizes and is fully adjustable to whatever size without crashing
<!-- Describe the behavior you observed when running your steps (i.e., buggy behavior). -->
- **Actual behavior**:
Crashes on resize horizontally or diagonally
<!-- **Logs?** Posting a log can help developers find your particular issue more easily. Please wrap your code in code blocks using triple back-ticks ``` to increase readability. -->
```
thread 'main' panicked at 'orbclient: failed to unmap memory in resize: Invalid argument', /home/papapop/.cargo/registry/src/github.com-1ecc6299db9ec823/orbclient-0.3.32/src/sys/orbital.rs:260:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
launcher: /ui/bin/editor (266) exited with exit status: 101
```
<!-- **Solution?** Have a solution in mind? Propose your solution below. -->
- **Proposed solution**:
Fix the unmapping error shown above
<!-- **Screenshots?** Make it easier to get your point across with screenshots. You can drag & drop or paste your images below. -->
## Optional references
<!-- If you have found issues or pull requests that are related to or blocking this issue, please link them below. See https://help.github.com/articles/autolinked-references-and-urls/ for more options. You can also link related code snippets by providing the permalink. See https://help.github.com/articles/creating-a-permanent-link-to-a-code-snippet/ for more information. -->
## Optional extras
<!-- If you have other relevant information not found in other sections, you can include it below. -->
<!-- **Code?** Awesome! You can also create a pull request with a reference to this issue. -->
<!-- **Files?** Attach your relevant files by dragging & dropping or pasting them below. -->
<!-- You also can preview your report before submitting it. Thanks for contributing to Redox! -->https://gitlab.redox-os.org/redox-os/redox/-/issues/1358Redox Menu Doesn't Close2023-06-13T02:04:55ZKtoksRedox Menu Doesn't Close<!-- Thank you for taking the time to submit an issue! By following these comments and filling out the sections below, you can help the developers get the necessary information to fix your issue. Please provide a single issue per report....<!-- Thank you for taking the time to submit an issue! By following these comments and filling out the sections below, you can help the developers get the necessary information to fix your issue. Please provide a single issue per report. You can also preview this report before submitting it. Feel free to modify/remove sections to fit the nature of your issue. -->
<!-- Please search to check that your issue has not been created already. By preventing duplicate issues, you can help keep the repository organized. If your current issue has already been created and is still unresolved, you can contribute by commenting there. -->
<!-- Replace the empty checkbox [ ] below with a checked one [x] if you have already searched for your issue. -->
- [x] I agree that I have searched opened and closed issues to prevent duplicates.
--------------------
## Description
<!-- Briefly summarize/describe the issue that you are experiencing below. -->
Upon starting the shell, it doesn't display the directory it is in.
## Environment info
<!-- To understand where your issue originates, please include some relevant information about your environment. -->
<!-- If you are using a pre-built release of Redox, please specify the release version below. -->
- Redox OS Release:
0.7.0 Commit: 8e0af3b8475f28670c38275971e454d3146561ac
<!-- If you have built Redox OS yourself, please provide the following information: -->
- Operating system:
Pop! OS
- `uname -a`:
`Linux pop-os 5.18.10-76051810-generic #202207071639~1659108431~22.04~c9172fb SMP PREEMPT_DYNAMIC Fri J x86_64 x86_64 x86_64 GNU/Linux`
- `rustc -V`:
`rustc 1.62.1 (e092d0b6b 2022-07-16)`
- `git rev-parse HEAD`:
`git rev-parse HEAD`
<!-- Depending on your issue, additional information about your environment (network config, package versions, dependencies, etc.) can also help. You can list that below. -->
- Environment:
Brand new install
Desktop PC
Ethernet
Recent Pop! install
## Steps to reproduce
<!-- If possible, please list the steps to reproduce ("trigger") your issue below. Being detailed definitely helps speed up bug fixes. -->
1. Started Redox for first time
2. Logged in
3. Clicked menu button on bottom left corner of screen, clicked out.
## Behavior
<!-- It may seem obvious to know what to expect, but isolating the behavior from everything else simplifies the development process. Remember to provide a single issue in this report. You can use the References section below to link your issues together. -->
<!-- Describe the behavior you expect your steps should yield (i.e., correct behavior). -->
- **Expected behavior**:
Menu closes upon clicking out, or on a menu object
<!-- Describe the behavior you observed when running your steps (i.e., buggy behavior). -->
- **Actual behavior**:
Menu stays visible, but unable to select objects upon further clicks until the menu button is selected again
<!-- **Logs?** Posting a log can help developers find your particular issue more easily. Please wrap your code in code blocks using triple back-ticks ``` to increase readability. -->
```
kernel::scheme::user:WARN -- Unaligned map size for context Some("/ui/bin/launcher")
```
<!-- **Solution?** Have a solution in mind? Propose your solution below. -->
- **Proposed solution**:
Fix the above warning that is displayed every time the menu is selected? Or perhaps the object is just not removed properly after selection
<!-- **Screenshots?** Make it easier to get your point across with screenshots. You can drag & drop or paste your images below. -->
![image](/uploads/f14b3fe657975f950fce431cafb1a916/image.png)
## Optional references
<!-- If you have found issues or pull requests that are related to or blocking this issue, please link them below. See https://help.github.com/articles/autolinked-references-and-urls/ for more options. You can also link related code snippets by providing the permalink. See https://help.github.com/articles/creating-a-permanent-link-to-a-code-snippet/ for more information. -->
## Optional extras
<!-- If you have other relevant information not found in other sections, you can include it below. -->
<!-- **Code?** Awesome! You can also create a pull request with a reference to this issue. -->
<!-- **Files?** Attach your relevant files by dragging & dropping or pasting them below. -->
<!-- You also can preview your report before submitting it. Thanks for contributing to Redox! -->https://gitlab.redox-os.org/redox-os/orbclient/-/issues/45Panic on resizing windows2022-08-03T17:09:23ZNagy Tiborxnagytibor@gmail.comPanic on resizing windowsAfter some recent Redox kernel/syscall changes orbclient started panicking on resizing windows:
```
thread 'main' panicked at 'orbclient: failed to unmap memory in resize: Invalid argument', /home/user/.cargo/registry/src/github.com-1ec...After some recent Redox kernel/syscall changes orbclient started panicking on resizing windows:
```
thread 'main' panicked at 'orbclient: failed to unmap memory in resize: Invalid argument', /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/orbclient-0.3.32/src/sys/orbital.rs:260:18
```
The panic is reproducible with any Redox desktop app with resizable windows.https://gitlab.redox-os.org/redox-os/kernel/-/issues/109initfs: Kernel panic when reading directory entries2022-07-29T21:56:31ZNagy Tiborxnagytibor@gmail.cominitfs: Kernel panic when reading directory entries**Repro:**
```rust
use std::{fs::File, io::{Read, Seek, SeekFrom}};
fn main() -> std::io::Result<()> {
let mut file = File::open("initfs:")?;
let mut pos1: [u8; 2] = [0, 0];
file.seek(SeekFrom::Start(1))?;
file.read_ex...**Repro:**
```rust
use std::{fs::File, io::{Read, Seek, SeekFrom}};
fn main() -> std::io::Result<()> {
let mut file = File::open("initfs:")?;
let mut pos1: [u8; 2] = [0, 0];
file.seek(SeekFrom::Start(1))?;
file.read_exact(&mut pos1)?;
println!("{:?}", pos1);
Ok(())
}
```
**Stack trace:**
```
KERNEL PANIC: panicked at 'index out of bounds: the len is 2 but the index is 2', src/scheme/initfs.rs:185:25
TRACE: FFFFFE80002947F0
FFFFFE80002947F0: FFFFFF00000BD167
FFFFFF00000BD010+0157
rust_begin_unwind
FFFFFE80002948F0: FFFFFF0000015C93
FFFFFF0000015C60+0033
core::panicking::panic_fmt
FFFFFE8000294930: FFFFFF0000015C56
FFFFFF0000015BF0+0066
core::panicking::panic_bounds_check
FFFFFE80002949A0: FFFFFF00000C475B
FFFFFF00000C4390+03CB
<kernel::scheme::initfs::InitFsScheme as syscall::scheme::scheme::Scheme>::read
FFFFFE8000294A40: FFFFFF00000C42DF
FFFFFF00000C4050+028F
syscall::scheme::scheme::Scheme::handle
FFFFFE8000294A90: FFFFFF00000BF277
FFFFFF00000BEF00+0377
kernel::syscall::fs::file_op
FFFFFE8000294B50: FFFFFF0000059A31
FFFFFF0000058BA0+0E91
kernel::syscall::syscall
FFFFFE8000294EE0: FFFFFF00000BCFB0
FFFFFF00000BCF40+0070
__inner_syscall_instruction
FFFFFE8000294F50: FFFFFF00000BCEF3
FFFFFF00000BCEB0+0043
kernel::arch::x86_64::interrupt::syscall::syscall_instruction
0000000000411EF0: 7FFFFFFFFFFFFFFF
B8483E8BFB894853: GUARD PAGE
CPU 1, PID ContextId(65)
```https://gitlab.redox-os.org/redox-os/kernel/-/issues/108initfs: Directory entries are not separated anymore2022-07-29T21:56:30ZNagy Tiborxnagytibor@gmail.cominitfs: Directory entries are not separated anymore**Repro:**
Open the shell then run:
```
$ ls initfs:/bin
pcidramfsnvmedlogdranddps2dvesadredoxfsinitzerodahcidnulldacpid
```
Notice how the directory names are clumped together without any separators. The `initfs:` scheme doesn't prop...**Repro:**
Open the shell then run:
```
$ ls initfs:/bin
pcidramfsnvmedlogdranddps2dvesadredoxfsinitzerodahcidnulldacpid
```
Notice how the directory names are clumped together without any separators. The `initfs:` scheme doesn't properly separate the directory entries anymore.https://gitlab.redox-os.org/redox-os/kernel/-/issues/107Kernel addresses not in agreement with "kernel" code model2023-08-12T00:57:47ZJacob Lorentzon4ldo2@protonmail.comKernel addresses not in agreement with "kernel" code modelCurrently, [the kernel target spec JSON specifies `"code-model": "kernel"`](https://gitlab.redox-os.org/redox-os/kernel/-/blob/b5a930170627e4d33b9a0eac1c61dd1d44a131e4/targets/x86_64-unknown-kernel.json). However, as per the System V ABI...Currently, [the kernel target spec JSON specifies `"code-model": "kernel"`](https://gitlab.redox-os.org/redox-os/kernel/-/blob/b5a930170627e4d33b9a0eac1c61dd1d44a131e4/targets/x86_64-unknown-kernel.json). However, as per the System V ABI (https://gitlab.com/x86-psABIs/x86-64-ABI), that code model requires all _symbols_ to be in the range 2^64 - 2^31 .. 2^64 - 2^24 (0xFFFF_FFFF_8000_0000..0xFFFF_FFFF_FF00_0000, 2032 MiB), whereas the kernel currently resides at 2^64 - 2^40 .. 2^64 - 2^39 (0xFFFF_FF00_0000_0000..0xFFFF_FF80_0000_0000, 510th PML4e counting from zero).
That said, we might want KASLR though (at least allow enabling it), in which case a more suitable code model might be the "small position independent code model" (AFAIK), also limiting the kernel size to 2032 MiB (three orders of magnitude more than the current kernel size of approximately 1 MiB).https://gitlab.redox-os.org/redox-os/redoxfs/-/issues/40Removing unncessary `fork` and `pipe`2022-03-18T19:42:40ZAditya Guptaadityag.ug19.cs@nitp.ac.inRemoving unncessary `fork` and `pipe`Currently in [src/bin/mount.rs](https://gitlab.redox-os.org/redox-os/redoxfs/-/blob/master/src/bin/mount.rs), the 'daemon' function (that then calls the mount to mount the filesystem) is called on another process (the 'child process' aft...Currently in [src/bin/mount.rs](https://gitlab.redox-os.org/redox-os/redoxfs/-/blob/master/src/bin/mount.rs), the 'daemon' function (that then calls the mount to mount the filesystem) is called on another process (the 'child process' after a `fork`). And the parent process just keeps on waiting for the `daemon` function in child process to end basically, and doing no other thing.
And the pipe was being used by the child and parent processes after fork, so it is not needed too.
Also, every function call in daemon is sync too.
Actually, I did this in an effort to make it more 'simpler' for myself... this is one of the result of it.https://gitlab.redox-os.org/redox-os/uefi/-/issues/3Convert into a workspace and import other UEFI crates2022-03-02T17:45:19ZTim CrawfordConvert into a workspace and import other UEFI cratesConvert this into a [workspace](https://doc.rust-lang.org/cargo/reference/workspaces.html) containing all of the UEFI crates.
```
uefi/
├── Cargo.toml
├── crates/
│ ├── uefi/
│ │ └── Cargo.toml
│ ├── uefi_alloc/
│ │ └── Carg...Convert this into a [workspace](https://doc.rust-lang.org/cargo/reference/workspaces.html) containing all of the UEFI crates.
```
uefi/
├── Cargo.toml
├── crates/
│ ├── uefi/
│ │ └── Cargo.toml
│ ├── uefi_alloc/
│ │ └── Cargo.toml
│ └── uefi_std/
│ └── Cargo.toml
└── target/
```
The top-level `Cargo.toml` would be a virtual manifest. That is, it would only contain a `workspace` section and not a `package` section.
```toml
[workspace]
members = [
"crates/*"
]
```https://gitlab.redox-os.org/redox-os/redox/-/issues/1355Git pull fails because latest kernel commit does not exist2021-12-06T16:19:28ZSahaj SarupGit pull fails because latest kernel commit does not existupdates to kernel submodule points to a commit that does not exist.
https://gitlab.redox-os.org/redox-os/kernel/-/tree/0ab4529eaade334d2c6b5d663e6d9e0165cae0f5updates to kernel submodule points to a commit that does not exist.
https://gitlab.redox-os.org/redox-os/kernel/-/tree/0ab4529eaade334d2c6b5d663e6d9e0165cae0f5https://gitlab.redox-os.org/redox-os/kernel/-/issues/106Bug: in set_unused2022-07-21T22:39:34ZmjdrBug: in set_unusedNot actually setting `COUNTER_MASK` bits to zero
Bug on:
```
https://gitlab.redox-os.org/redox-os/kernel/-/blob/6f7749365826aba49e76c31029666281018d07e8/src/arch/riscv64/paging/entry.rs#L37
```Not actually setting `COUNTER_MASK` bits to zero
Bug on:
```
https://gitlab.redox-os.org/redox-os/kernel/-/blob/6f7749365826aba49e76c31029666281018d07e8/src/arch/riscv64/paging/entry.rs#L37
```https://gitlab.redox-os.org/redox-os/ion/-/issues/1009IS The Shell Being Maintained2021-08-07T09:02:28Zlinux6osIS The Shell Being Maintainedis ion shell being manintained if it is then in the AUR(aur.archlinux.org) it is not being updated from 2 years and how do i compile it so i can update whenever there is a bug fix or release
i want to put it in my distro so thats why i a...is ion shell being manintained if it is then in the AUR(aur.archlinux.org) it is not being updated from 2 years and how do i compile it so i can update whenever there is a bug fix or release
i want to put it in my distro so thats why i am raising the issuehttps://gitlab.redox-os.org/redox-os/ion/-/issues/1007Why does the "dirs" buildin behave the way it does?2021-08-07T09:14:26ZKrisWhy does the "dirs" buildin behave the way it does?bug: description
expect: outcome description
related: none
code: input
```
cd Downloads/
dirs
shell code
```
cd Downloads/
dirs
expect: output
```
~/Downloads
result
```
/home/user/Downloads
kernel: linux5.12.14_1
version: `ion 1....bug: description
expect: outcome description
related: none
code: input
```
cd Downloads/
dirs
shell code
```
cd Downloads/
dirs
expect: output
```
~/Downloads
result
```
/home/user/Downloads
kernel: linux5.12.14_1
version: `ion 1.0.0-alpha (x86_64-unknown-linux-gnu)
rev 2bc8826a97929b1878375a5c747e5c4cfed2b10b`
interaction: none
behavior of bash/dash/zsh/fish/oil: in bash and zsh the dirs buildin doesn't show the user's home directoryhttps://gitlab.redox-os.org/redox-os/redoxfs/-/issues/39redoxfs fails to compile on systems with libfuse >=3.02023-03-21T19:01:20ZLiam Naddellredoxfs fails to compile on systems with libfuse >=3.0Steps to reproduce:
1. Install Gentoo
2. install fuse as directed by bootstrap.sh -d
3. git clone https://gitlab.redox-os.org/redox-os/redoxfs.git
4. cargo build
5.
```
Caused by:
process didn't exit successfully: `/home/liam/repos/r...Steps to reproduce:
1. Install Gentoo
2. install fuse as directed by bootstrap.sh -d
3. git clone https://gitlab.redox-os.org/redox-os/redoxfs.git
4. cargo build
5.
```
Caused by:
process didn't exit successfully: `/home/liam/repos/redoxfs/target/debug/build/fuse-af7cecec4946dbaf/build-script-build` (exit status: 101)
--- stdout
cargo:rerun-if-env-changed=FUSE_NO_PKG_CONFIG
cargo:rerun-if-env-changed=PKG_CONFIG
cargo:rerun-if-env-changed=FUSE_STATIC
cargo:rerun-if-env-changed=FUSE_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Failure { command: "\"pkg-config\" \"--libs\" \"--cflags\" \"fuse\" \"fuse >= 2.6.0\"", output: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "Package fuse was not found in the pkg-config search path.\nPerhaps you should add the directory containing `fuse.pc'\nto the PKG_CONFIG_PATH environment variable\nPackage 'fuse', required by 'virtual:world', not found\nPackage 'fuse', required by 'virtual:world', not found\n" } }', /home/liam/.cargo/registry/src/github.com-1ecc6299db9ec823/fuse-0.3.1/build.rs:10:76
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed
```
Looking at this error you might seek to blame upstream, but upstream will not fix the issue.
from https://github.com/zargony/fuse-rs/issues/155
> fuse-rs is in a bit of a languishing state, you might want to open a similar issue with https://github.com/cberner/fuser which is a fork of this project and is more actively developed.
How to move forwards: I was able to get zargony's library to compile by changing the build.rs script to search for fuse3, but it might be better to switch to using fuser. I tried switching redoxfs to fuser and got 18 build errors, which doesn't seem that bad. Most of them were related to Timespecs and differences in the number of arguments. The other thing would be to fork fuse to gitlab, change build.rs, then just use that instead of upstream fuse. Since fuse is in a "languishing state", it might not be the worst option.
Aside, whatever the preferred solution is, I'd be happy to work on it.https://gitlab.redox-os.org/redox-os/redox/-/issues/1346boot redox_0.6.0_harddrive.bin fail on macos by qemu-system-x86_642021-09-15T15:09:47ZChairouboot redox_0.6.0_harddrive.bin fail on macos by qemu-system-x86_64<!-- Thank you for taking the time to submit an issue! By following these comments and filling out the sections below, you can help the developers get the necessary information to fix your issue. Please provide a single issue per report....<!-- Thank you for taking the time to submit an issue! By following these comments and filling out the sections below, you can help the developers get the necessary information to fix your issue. Please provide a single issue per report. You can also preview this report before submitting it. Feel free to modify/remove sections to fit the nature of your issue. -->
<!-- Please search to check that your issue has not been created already. By preventing duplicate issues, you can help keep the repository organized. If your current issue has already been created and is still unresolved, you can contribute by commenting there. -->
<!-- Replace the empty checkbox [ ] below with a checked one [x] if you have already searched for your issue. -->
- [ ] I agree that I have searched opened and closed issues to prevent duplicates.
--------------------
## Description
When I boot the img with command
qemu-system-x86_64 -serial mon:stdio -d cpu_reset -d guest_errors -smp 1 -m 1024 -s -machine q35 -device ich9-intel-hda -device hda-duplex -net nic,model=e1000 -net user -device nec-usb-xhci,id=xhci -drive file=redox_0.6.0_harddrive.bin,format=raw
It's fail with error message
Required CPU features are not present
and halt out there.
## Environment info
<!-- To understand where your issue originates, please include some relevant information about your environment. -->
<!-- If you are using a pre-built release of Redox, please specify the release version below. -->
- Redox OS Release:
0.6.0
<!-- If you have built Redox OS yourself, please provide the following information: -->
- Operating system:
MacOS Big Sur 11.4
- `uname -a`:
Darwin
- `rustc -V`:
rustc 1.47.0-nightly (6c8927b0c 2020-07-26)
- `git rev-parse HEAD`:
none, I use the redox_0.6.0_harddrive.bin.gz
<!-- Depending on your issue, additional information about your environment (network config, package versions, dependencies, etc.) can also help. You can list that below. -->
- Replace me:
none
## Steps to reproduce
<!-- If possible, please list the steps to reproduce ("trigger") your issue below. Being detailed definitely helps speed up bug fixes. -->
1. run qemu-system-x86_64 -serial mon:stdio -d cpu_reset -d guest_errors -smp 1 -m 1024 -s -machine q35 -device ich9-intel-hda -device hda-duplex -net nic,model=e1000 -net user -device nec-usb-xhci,id=xhci -drive file=redox_0.6.0_harddrive.bin,format=raw
and halt
## Behavior
<!-- It may seem obvious to know what to expect, but isolating the behavior from everything else simplifies the development process. Remember to provide a single issue in this report. You can use the References section below to link your issues together. -->
<!-- Describe the behavior you expect your steps should yield (i.e., correct behavior). -->
- **Expected behavior**:
booting normaly
<!-- Describe the behavior you observed when running your steps (i.e., buggy behavior). -->
- **Actual behavior**:
It's fail with error message
Required CPU features are not present
and halt out there.
<!-- **Logs?** Posting a log can help developers find your particular issue more easily. Please wrap your code in code blocks using triple back-ticks ``` to increase readability. -->
```
I have not idea about log when the qemu halt
```
<!-- **Solution?** Have a solution in mind? Propose your solution below. -->
- **Proposed solution**:
Replace me
<!-- **Screenshots?** Make it easier to get your point across with screenshots. You can drag & drop or paste your images below. -->
## Optional references
<!-- If you have found issues or pull requests that are related to or blocking this issue, please link them below. See https://help.github.com/articles/autolinked-references-and-urls/ for more options. You can also link related code snippets by providing the permalink. See https://help.github.com/articles/creating-a-permanent-link-to-a-code-snippet/ for more information. -->
Related to:
- #0000 Remove me
- Replace me
- ...
Blocked by:
- #0000 Remove me
- ...
## Optional extras
<!-- If you have other relevant information not found in other sections, you can include it below. -->
Replace me
<!-- **Code?** Awesome! You can also create a pull request with a reference to this issue. -->
<!-- **Files?** Attach your relevant files by dragging & dropping or pasting them below. -->
<!-- You also can preview your report before submitting it. Thanks for contributing to Redox! -->https://gitlab.redox-os.org/redox-os/redox/-/issues/1345bootstrap.sh doesn't support CentOS 72023-06-13T02:12:52ZChairoubootstrap.sh doesn't support CentOS 7I use a old OS CentOS 7 , run bootstrap.sh print the following under
Fatal error: \Unsupported platform, please open an issue
So I'm here :)I use a old OS CentOS 7 , run bootstrap.sh print the following under
Fatal error: \Unsupported platform, please open an issue
So I'm here :)https://gitlab.redox-os.org/redox-os/redox/-/issues/1344redox-os.org certificate expired2023-01-16T18:21:00Ztecywiz121redox-os.org certificate expired#1311 popping back up again.#1311 popping back up again.