1. 18 Jul, 2020 2 commits
    • Ahmed Abd El Mawgood's avatar
      Add gdb history files to .gitignore · dc64627a
      Ahmed Abd El Mawgood authored
      dc64627a
    • Ahmed Abd El Mawgood's avatar
      Fix wrong TLS resolving · d4b23912
      Ahmed Abd El Mawgood authored
      I attempted fixing this issue before at 43fbaf99. Although it did work,
      it worked wrong, and it was just consistently working (but in wrong way)
      until it didn't.
      
      Since this is (hopefully) the real fix, I will try to explain exactly
      what is going on.
      
      This is explaination by example:
      
      our TLS is memory of size 0x1000 starting at 0x7ffff6c50000,
      but the real size is 0x000068 so we have padding stored at master.offset
      = 0xf98
      
      Now our symbol looks as follows
      
        Offset          Type                Sym. Value    Name
      000000432b20  R_X86_64_DTPOFF64   0000000000000058 errno
      
      The old code did 0x7ffff6c50000 + 0xf98 + 000000432b20 which is
      obviosly overflowing the memory and wrong.
      
      The right way 0x7ffff6c50000 + 0xf98 + 0000000000000058.
      
      THe Tls base part and offset are added at __tls_get_addr function.
      What is left is storing the 0x58 at the relocation address. The problem
      is that we don't have 0x58, but we have (binary base + 0x58) in global
      symbol table and binary base so what we store is the (binarybase + 0x58
      - binary base).
      
      I hope this does turn out to be wrong.
      d4b23912
  2. 15 Jul, 2020 1 commit
  3. 09 Jul, 2020 1 commit
  4. 08 Jul, 2020 4 commits
  5. 01 Jul, 2020 1 commit
  6. 29 Jun, 2020 4 commits
  7. 27 Jun, 2020 1 commit
  8. 25 Jun, 2020 1 commit
  9. 24 Jun, 2020 5 commits
  10. 23 Jun, 2020 1 commit
  11. 22 Jun, 2020 4 commits
  12. 20 Jun, 2020 3 commits
  13. 19 Jun, 2020 2 commits
  14. 14 Jun, 2020 3 commits
    • Jeremy Soller's avatar
      Merge branch 'headers' into 'master' · ca8b848b
      Jeremy Soller authored
      Headers
      
      See merge request redox-os/relibc!280
      ca8b848b
    • Ahmed Abd El Mawgood's avatar
      Add sys/select.h to sys/types.h · f4d95ce4
      Ahmed Abd El Mawgood authored
      This was triggered by gcc for some reason It included sys/types.h and
      assumed sys/select.h to be there. And that seams to be the case in musl.
      
      The problem with relibc here is that sys/types.h is are part of relibc
      "include/*.h" files, while sys/select.h is generated by cbindgen. That
      makes it impossible to #include select.h in types.h epsecially that
      there are files like fcntl.c that uses types.h. They would complain
      about missing headers. I fixed this by renaming sys/types.h to
      sys/types_internal.h and then generating types.h using cbindgen as well
      except for that. however fcntl and dlmalloc can include types_internal
      instead of types.h
      f4d95ce4
    • Ahmed Abd El Mawgood's avatar
      Make stdbool.h C++ compatiable · a125b8be
      Ahmed Abd El Mawgood authored
      The problem here is that _Bool type is not defined in C++ yet this file
      is using it. That leads to issues when compiling gcc. I borrowed the
      same techniques used in other stdbool.h
      a125b8be
  15. 13 Jun, 2020 3 commits
    • Ahmed Abd El Mawgood's avatar
      Fix the avoid accessing errno issue from ld_so for real this time · 81da1bb1
      Ahmed Abd El Mawgood authored
      This patch implements access function for both redox and linux and makes
      sure that neither access errno variable
      81da1bb1
    • no name's avatar
      Revert "Fix compilation on Redox by removing use of access in ld_so" · d5b63a85
      no name authored and Ahmed Abd El Mawgood's avatar Ahmed Abd El Mawgood committed
      This reverts commit d9bacaec.
      d5b63a85
    • no name's avatar
      Revert "Handle missing paths in load_library search without using access" · c3ae8022
      no name authored and Ahmed Abd El Mawgood's avatar Ahmed Abd El Mawgood committed
      This reverts commit b0dde81c.
      
      The main issue was not with "access" being used, it was with errno being
      accessed. This patch accesses errno as well
      
      LD_LIBRARY_PATH="/folder/with/no/libc" ./a.out
      
      gives segfault with the following stack trace
      
      0x00000000004d1cae in relibc::platform::sys::e (sys=18446744073709551614) at src/platform/linux/mod.rs:54
       54                  errno = -(sys as isize) as c_int;
      (gdb) bt
       #0  0x00000000004d1cae in relibc::platform::sys::e (sys=18446744073709551614) at src/platform/linux/mod.rs:54
       #1  0x00000000004d361e in <relibc::platform::sys::Sys as relibc::platform::pal::Pal>::open (path=0x5555555634c0, oflag=524288, mode=0) at src/platform/linux/mod.rs:330
       #2  0x000000000049a2ad in relibc::fs::File::open (path=0x5555555634c0, oflag=524288) at src/fs.rs:28
       #3  0x0000000000482b49 in relibc::ld_so::linker::Linker::load_recursive (self=0x7fffffffdd30, name=..., path=...) at src/ld_so/linker.rs:119
       #4  0x0000000000484963 in relibc::ld_so::linker::Linker::load_library (self=0x7fffffffdd30, name=...) at src/ld_so/linker.rs:184
       #5  0x0000000000483b53 in relibc::ld_so::linker::Linker::load_data (self=0x7fffffffdd30, name=..., data=...) at src/ld_so/linker.rs:152
       #6  0x00000000004831fe in relibc::ld_so::linker::Linker::load_recursive (self=0x7fffffffdd30, name=..., path=...) at src/ld_so/linker.rs:140
       #7  0x000000000048228a in relibc::ld_so::linker::Linker::load (self=0x7fffffffdd30, name=..., path=...) at src/ld_so/linker.rs:97
       #8  0x0000000000414a3b in relibc_ld_so_start (sp=0x7fffffffe310, ld_entry=4198896) at src/ld_so/start.rs:182
       #9  0x0000000000401209 in _start () at src/ld_so/src/lib.rs:10
       #10 0x0000000000000001 in ?? ()
       #11 0x00007fffffffe592 in ?? ()
       #12 0x0000000000000000 in ?? ()
      c3ae8022
  16. 10 Jun, 2020 1 commit
  17. 07 Jun, 2020 3 commits