Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
ion
ion
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 87
    • Issues 87
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • redox-os
  • ionion
  • Merge Requests
  • !864

Closed
Opened Sep 23, 2018 by Grant Cooksey@grant.cooksey
  • Report abuse
Report abuse

Avoid writing prompt for multi-line input #801

Overview

There was a bug where the shell prompt was being written during multi-line input during interactive shell sessions.

Solution

Stop printing the shell prompt when quotes are open and instead print quote>.

Notes

I'm not sure is there is a good way to add some tests around this since it only applies to interactive shell sessions. If anyone has an idea of how to do this, I'll be happy to add some.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

-# All repo/branch refs have been quoted to allow support for special characters (such as #my-branch)
git fetch "https://gitlab.redox-os.org/grant.cooksey/ion.git" "bug-prompt-in-multiline-input"
git checkout -b "grant.cooksey/ion-bug-prompt-in-multiline-input" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "grant.cooksey/ion-bug-prompt-in-multiline-input"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 10
  • Commits 2
  • Changes 3
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: redox-os/ion!864