Yes this commit message sucks you should really just squash all commits :)

This reverts commit cfd47114.

Prefer pass-by-value over pass-by-reference, but only for private
functions.  Suppress the warning generally, because it's triggered by
public functions that can't be changed backwards-compatibly.

Signed-off-by: Toby Lawrence <toby@nuclearfurnace.com>