Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
seahash
seahash
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • redox-os
  • seahashseahash
  • Issues
  • #9

Closed
Open
Opened Aug 17, 2020 by Joonas Koivunen@koivunejContributor

unaligned u64 reads

Not sure if this could be related to the ARM performance #7 but I was just thinking of the unsafe code, for example in buffer.rs or in stream.rs. I think there's no guarantee that a pointer to &[u8] is good for reading u64.

Might be that we'd need to do a loop of smaller to align to align_of::<u64>() and read the non-aligned suffix in similar slower way.

Apologies if this has already been discussed to death or if I am misreading and missing some alignment enforcing part.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: redox-os/seahash#9