Published seahash 3.0.6 fails test buffer::tests::pop
Its unclear how serious this failure is, or what the cause is, but generally hashes not matching in tests seems like a bad thing.
Trying with git master doesn't exhibit this, so it looks like !1 (merged) fixes this.
If so, please consider this bug to be:
- For visibility reasons
- A vote for a release of seahash with the fix.
seahash-3.0.6 $ cargo test
warning: unused doc comment
--> src/buffer.rs:43:13
|
43 | / /// The end of the "main segment", i.e. the biggest buffer s.t. the length is divisible
44 | | /// by 32.
| |______________________^
45 | let end_ptr = buf.as_ptr().offset(buf.len() as isize & !0x1F);
| -------------------------------------------------------------- rustdoc does not generate documentation for statements
|
= note: `#[warn(unused_doc_comments)]` on by default
warning: `...` range patterns are deprecated
--> src/buffer.rs:72:18
|
72 | 1...7 => {
| ^^^ help: use `..=` for an inclusive range
|
= note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default
warning: `...` range patterns are deprecated
--> src/buffer.rs:90:18
|
90 | 9...15 => {
| ^^^ help: use `..=` for an inclusive range
warning: `...` range patterns are deprecated
--> src/buffer.rs:116:19
|
116 | 17...23 => {
| ^^^ help: use `..=` for an inclusive range
warning: variable does not need to be mutable
--> src/buffer.rs:205:13
|
205 | let mut a = self.a;
| ----^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
warning: unused doc comment
--> src/buffer.rs:43:13
|
43 | / /// The end of the "main segment", i.e. the biggest buffer s.t. the length is divisible
44 | | /// by 32.
| |______________________^
45 | let end_ptr = buf.as_ptr().offset(buf.len() as isize & !0x1F);
| -------------------------------------------------------------- rustdoc does not generate documentation for statements
|
= note: `#[warn(unused_doc_comments)]` on by default
warning: `...` range patterns are deprecated
--> src/buffer.rs:72:18
|
72 | 1...7 => {
| ^^^ help: use `..=` for an inclusive range
|
= note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default
warning: `...` range patterns are deprecated
--> src/buffer.rs:90:18
|
90 | 9...15 => {
| ^^^ help: use `..=` for an inclusive range
warning: `...` range patterns are deprecated
--> src/buffer.rs:116:19
|
116 | 17...23 => {
| ^^^ help: use `..=` for an inclusive range
warning: variable does not need to be mutable
--> src/buffer.rs:205:13
|
205 | let mut a = self.a;
| ----^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
Finished test [unoptimized + debuginfo] target(s) in 0.01s
Running target/debug/deps/seahash-d50b68ff7b5b2e86
running 12 tests
test buffer::tests::not_equal ... ok
test buffer::tests::pop ... FAILED
test buffer::tests::shakespear ... ok
test buffer::tests::position_depedent ... ok
test buffer::tests::push ... ok
test buffer::tests::zero_senitive ... ok
test helper::tests::read_int_ ... ok
test helper::tests::diffuse_test_vectors ... ok
test helper::tests::read_u64_ ... ok
test reference::tests::shakespear ... ok
test buffer::tests::seq ... ok
test buffer::tests::zero ... ok
failures:
---- buffer::tests::pop stdout ----
thread 'buffer::tests::pop' panicked at 'assertion failed: `(left == right)`
left: `11308796940792507029`,
right: `5634333896585159103`', src/buffer.rs:373:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
failures:
buffer::tests::pop
test result: FAILED. 11 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
error: test failed, to rerun pass '--lib'