sodium issueshttps://gitlab.redox-os.org/redox-os/sodium/-/issues2020-06-23T07:08:18Zhttps://gitlab.redox-os.org/redox-os/sodium/-/issues/85Sodium didn't close window when usin `q` command in prompt mode2020-06-23T07:08:18ZJacobo Da RivaSodium didn't close window when usin `q` command in prompt modeRunning Redox on qemu under Debian 10.
Sodium installed with pkg.
I open the application, create a file and try to exit without saving. If I use the close button in the window it works fine, but if I go to prompt mode and type command `...Running Redox on qemu under Debian 10.
Sodium installed with pkg.
I open the application, create a file and try to exit without saving. If I use the close button in the window it works fine, but if I go to prompt mode and type command `q`, the window stay opened forever and I can't close it even clicking in the close button. I need to power down the emulator.
![error-sodium](/uploads/7d28dc4b4bd2744cee1ac209e7d5e48a/error-sodium.png)https://gitlab.redox-os.org/redox-os/sodium/-/issues/84Sodium reads input from mouse instead of keyboard.2019-12-10T01:57:16ZSamwiseFilmoremggmugginsmc@gmail.comSodium reads input from mouse instead of keyboard.*Created by: pi-pi3 (Moved from https://gitlab.redox-os.org/redox-os/redox/issues/920)*
**Reproduction**: Type the following in vt.
```
sudo pkg install sodium
/ui/bin/sodium
```
Then try to type anything in sodium and try moving the mo...*Created by: pi-pi3 (Moved from https://gitlab.redox-os.org/redox-os/redox/issues/920)*
**Reproduction**: Type the following in vt.
```
sudo pkg install sodium
/ui/bin/sodium
```
Then try to type anything in sodium and try moving the mouse around.
**Expected behavior**: Sodium works and reads input from keyboard.
**Actual behavior**: Sodium seems to be reading input from the mouse. It doesn't react to keyboard input whatsoever, but when I move my mouse, it says stuff like `unknown command <some weird unicode character>` (picture bellow). The character that is actually shown switches when I move my mouse and from what I can tell it reads it from absolute mouse position, not the relative mouse movement.
**Build information**:
```
rustc -V: rustc 1.18.0-nightly (28a742997 2017-04-13)
git rev-parse HEAD: 69bc31f7addb64378aea1302523609017503b7b1
qemu-system-x86_64 --version: QEMU emulator version 2.8.0
uname -a: Linux Kerberos 4.8.12-3-ARCH #1 SMP PREEMPT Thu Dec 8 16:10:23 CET 2016 x86_64 GNU/Linux
```
**Misc**:
Keyboard: AmazonBasics KU-0833
Mouse: Mad Catz R.A.T. 3
In the image below I "pressed" the `i` key by finding some specific location with my mouse and therefore entered insert mode.
![redox-sodium](https://cloud.githubusercontent.com/assets/24700626/25066613/7c072b02-222b-11e7-80dc-2656e355e45a.png)https://gitlab.redox-os.org/redox-os/sodium/-/issues/83Panics when saving a new file without specifying a filename2023-02-21T16:20:49ZStéphane CampinasPanics when saving a new file without specifying a filenameIn prompt, if you try to save without passing a file name and there is not yet a file associated to the buffer's content, it panics.
Steps:
- with 88f55176c150db384e6b7c79553ee4b5e90dad8d and `rustc 1.32.0-nightly (9fefb6766 2018-11-13)...In prompt, if you try to save without passing a file name and there is not yet a file associated to the buffer's content, it panics.
Steps:
- with 88f55176c150db384e6b7c79553ee4b5e90dad8d and `rustc 1.32.0-nightly (9fefb6766 2018-11-13)`
- `cargo run --features orbital`
- enter `insert` mode and write some text
- enter `prompt` and execute `w`
```
Starting Sodium
First redraw of the screen
thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0', /rustc/9fefb67669f00c25b476e7a80c9c9300a987d517/src/libcore/slice/mod.rs:2447:10
stack backtrace:
0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
at libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
1: std::sys_common::backtrace::_print
at libstd/sys_common/backtrace.rs:71
2: std::panicking::default_hook::{{closure}}
at libstd/sys_common/backtrace.rs:59
at libstd/panicking.rs:211
3: std::panicking::default_hook
at libstd/panicking.rs:227
4: std::panicking::rust_panic_with_hook
at libstd/panicking.rs:476
5: std::panicking::continue_panic_fmt
at libstd/panicking.rs:390
6: rust_begin_unwind
at libstd/panicking.rs:325
7: core::panicking::panic_fmt
at libcore/panicking.rs:77
8: core::panicking::panic_bounds_check
at libcore/panicking.rs:59
9: <usize as core::slice::SliceIndex<[T]>>::index
at /rustc/9fefb67669f00c25b476e7a80c9c9300a987d517/src/libcore/slice/mod.rs:2447
10: core::slice::<impl core::ops::index::Index<I> for [T]>::index
at /rustc/9fefb67669f00c25b476e7a80c9c9300a987d517/src/libcore/slice/mod.rs:2315
11: <alloc::vec::Vec<T> as core::ops::index::Index<I>>::index
at /rustc/9fefb67669f00c25b476e7a80c9c9300a987d517/src/liballoc/vec.rs:1653
12: sodium::io::file::<impl sodium::state::editor::Editor>::write
at src/io/file.rs:43
13: sodium::core::prompt::<impl sodium::state::editor::Editor>::invoke
at src/core/prompt.rs:144
14: sodium::core::exec::<impl sodium::state::editor::Editor>::exec
at src/core/exec.rs:279
15: sodium::state::editor::Editor::init
at src/state/editor.rs:321
16: sodium::main
at src/main.rs:24
17: std::rt::lang_start::{{closure}}
at /rustc/9fefb67669f00c25b476e7a80c9c9300a987d517/src/libstd/rt.rs:74
18: std::panicking::try::do_call
at libstd/rt.rs:59
at libstd/panicking.rs:310
19: __rust_maybe_catch_panic
at libpanic_unwind/lib.rs:102
20: std::rt::lang_start_internal
at libstd/panicking.rs:289
at libstd/panic.rs:398
at libstd/rt.rs:58
21: std::rt::lang_start
at /rustc/9fefb67669f00c25b476e7a80c9c9300a987d517/src/libstd/rt.rs:74
22: main
23: __libc_start_main
24: _start
```https://gitlab.redox-os.org/redox-os/sodium/-/issues/82File could not be opened2018-07-03T15:15:34ZJeremy SollerFile could not be opened*Created by: sajattack*
Whenever I try to save with `;w` I get this message. Could be related to changes in opendir? Not sure.*Created by: sajattack*
Whenever I try to save with `;w` I get this message. Could be related to changes in opendir? Not sure.https://gitlab.redox-os.org/redox-os/sodium/-/issues/72Photo in README does not appear2018-07-03T15:15:34ZJeremy SollerPhoto in README does not appear*Created by: naltun*
The photo in the README for `sodium` does not appear, and the file redirects to a 404 page. The README specifies `https://github.com/redox-os/assets/raw/master/Sodium_logo.png` as the file link, but the logo appears...*Created by: naltun*
The photo in the README for `sodium` does not appear, and the file redirects to a 404 page. The README specifies `https://github.com/redox-os/assets/raw/master/Sodium_logo.png` as the file link, but the logo appears to be [here](https://github.com/redox-os/assets/blob/master/logos/sodium/Sodium_logo.png) and in [raw form here](https://github.com/redox-os/assets/blob/master/logos/sodium/Sodium_logo.png?raw=true).https://gitlab.redox-os.org/redox-os/sodium/-/issues/70Sodium unresponsive in Redox (QEMU in OSX)2018-06-13T19:39:51ZJeremy SollerSodium unresponsive in Redox (QEMU in OSX)*Created by: kenan-rhoton*
Upon launching Sodium within Redox running in QEMU on my OSX Machine, the editor is launched but is unresponsive to any action except mouse click, upon which it imediately exits with:
`C'ya`
And no other...*Created by: kenan-rhoton*
Upon launching Sodium within Redox running in QEMU on my OSX Machine, the editor is launched but is unresponsive to any action except mouse click, upon which it imediately exits with:
`C'ya`
And no other output. Amy I doing something wrong? Did I forget to configure something?https://gitlab.redox-os.org/redox-os/sodium/-/issues/65`o` command sometimes inconsitent2018-06-13T19:39:51ZJeremy Soller`o` command sometimes inconsitent*Created by: LordPython*
The `o` command is sometimes inconsistent about where the new line gets created: sometimes it behaves as expected, creating a new line and entering insert mode at the beginning of the new line, but sometimes it ...*Created by: LordPython*
The `o` command is sometimes inconsistent about where the new line gets created: sometimes it behaves as expected, creating a new line and entering insert mode at the beginning of the new line, but sometimes it instead creates a new line *before* the current line and enters insert mode at the beginning of the current line (instead of the newly created line).
I'm not completely sure what I did to get this to happen, but here's an example of how it's behaving:
![example](https://cloud.githubusercontent.com/assets/2464249/23935054/0b83b40a-0920-11e7-980f-585c7cb76780.gif)
https://gitlab.redox-os.org/redox-os/sodium/-/issues/59help.txt h and l movement backwards2018-07-03T15:15:34ZJeremy Sollerhelp.txt h and l movement backwards*Created by: ducks*
In help.txt, there is a mixup and it shows h goes right and l goes left.
*Created by: ducks*
In help.txt, there is a mixup and it shows h goes right and l goes left.
https://gitlab.redox-os.org/redox-os/sodium/-/issues/57expected type `orbclient::Window` found type `Box<orbclient::Window>` during ...2018-07-03T15:15:34ZJeremy Sollerexpected type `orbclient::Window` found type `Box<orbclient::Window>` during compile*Created by: ducks*
**Reproduction**: run "cargo run --features orbital"
**Expected behavior**: sodium runs
**Actual behavior**: compile fails with error.
```
src/state/editor.rs:188:21: 188:27 error: mismatched types [E0308]
src/sta...*Created by: ducks*
**Reproduction**: run "cargo run --features orbital"
**Expected behavior**: sodium runs
**Actual behavior**: compile fails with error.
```
src/state/editor.rs:188:21: 188:27 error: mismatched types [E0308]
src/state/editor.rs:188 window: window,
^~~~~~
src/state/editor.rs:188:21: 188:27 help: run `rustc --explain E0308` to see a detailed explanation
src/state/editor.rs:188:21: 188:27 note: expected type `orbclient::Window`
src/state/editor.rs:188:21: 188:27 note: found type `Box<orbclient::Window>`
error: aborting due to previous error
error: Could not compile `sodium`.
```
**Misc**:
The root of this issue seems to be that I only had orbclient 0.1.8 installed.
I think this is what I got when I first ran Sodium. But since the dep is 0.1, I was not updated
to the newer versions and to the current 0.1.12 because only the patch version changed.
https://gitlab.redox-os.org/redox-os/sodium/-/issues/56Add line number option2018-07-03T15:15:34ZJeremy SollerAdd line number option*Created by: ducks*
Add options "line_numbers" and "ln" to toggle line numbers at the start of each line.
*Created by: ducks*
Add options "line_numbers" and "ln" to toggle line numbers at the start of each line.
https://gitlab.redox-os.org/redox-os/sodium/-/issues/54"highlight" option typo -- hightlight2018-07-03T15:15:34ZJeremy Soller"highlight" option typo -- hightlight*Created by: ducks*
When trying to match options, Sodium is looking for "hightlight" instead of highlight.
This is occuring here:
https://github.com/rjgoldsborough/sodium/blob/master/src/state/options.rs#L29
and here:
https://github.c...*Created by: ducks*
When trying to match options, Sodium is looking for "hightlight" instead of highlight.
This is occuring here:
https://github.com/rjgoldsborough/sodium/blob/master/src/state/options.rs#L29
and here:
https://github.com/rjgoldsborough/sodium/blob/master/src/state/options.rs#L40
https://gitlab.redox-os.org/redox-os/sodium/-/issues/52Add word navigation -- [numeral] WORDs backward2022-05-08T02:33:31ZJeremy SollerAdd word navigation -- [numeral] WORDs backward*Created by: ducks*
**Reproduction**: enter insert mode. enter "this is some text". use space+shift to reenter normal mode.
use 'B'.
**Expected behavior**: cursor moves to the previous WORD.
**Actual behavior**: b and B are used for c...*Created by: ducks*
**Reproduction**: enter insert mode. enter "this is some text". use space+shift to reenter normal mode.
use 'B'.
**Expected behavior**: cursor moves to the previous WORD.
**Actual behavior**: b and B are used for cursor management.
@ticki, do you have any thoughts on which keys to use here since b and B are already used?
https://gitlab.redox-os.org/redox-os/sodium/-/issues/51Add word navigation -- [numeral] WORDs forward2018-07-03T15:15:35ZJeremy SollerAdd word navigation -- [numeral] WORDs forward*Created by: ducks*
**Reproduction**: enter insert mode. enter "this is some text". use space+shift to reenter normal mode. use gg to go to beginning of line. use 'W'.
**Expected behavior**: cursor moves to the next WORD
**Actual beha...*Created by: ducks*
**Reproduction**: enter insert mode. enter "this is some text". use space+shift to reenter normal mode. use gg to go to beginning of line. use 'W'.
**Expected behavior**: cursor moves to the next WORD
**Actual behavior**: unknown command "W".
https://gitlab.redox-os.org/redox-os/sodium/-/issues/48next_ocur doesn't work when current cursor equals searched char2018-07-03T15:15:35ZJeremy Sollernext_ocur doesn't work when current cursor equals searched char*Created by: ducks*
**Reproduction**: enter insert mode. enter "this is zest and this is more zest". use shift+space to return to normal mode. use gg to return to beginning of the line. use 'tz' or move to the first z. use 'tz'.
**Expe...*Created by: ducks*
**Reproduction**: enter insert mode. enter "this is zest and this is more zest". use shift+space to return to normal mode. use gg to return to beginning of the line. use 'tz' or move to the first z. use 'tz'.
**Expected behavior**: cursor goes to the second z.
**Actual behavior**: cursor stays on first, current z.
https://gitlab.redox-os.org/redox-os/sodium/-/issues/46previous_ocur is not working2018-07-03T15:15:35ZJeremy Sollerprevious_ocur is not working*Created by: ducks*
**Reproduction**: enter insert mode. type "zest some is this". use shift+space to drop back into normal mode. use "fz" to find the z in zest.
**Expected behavior**: cursor goes to the z in zest
**Actual behavior**:...*Created by: ducks*
**Reproduction**: enter insert mode. type "zest some is this". use shift+space to drop back into normal mode. use "fz" to find the z in zest.
**Expected behavior**: cursor goes to the z in zest
**Actual behavior**: cursor stays at the end of the line
Related to #45 but for previous vs next
https://gitlab.redox-os.org/redox-os/sodium/-/issues/44next_ocur does not work2018-07-03T15:15:35ZJeremy Sollernext_ocur does not work*Created by: ducks*
**Reproduction**: enter insert mode. type "this is some zest". use shift+space to drop back into normal mode. use gg to go back to the start of the line. use "tz" to find the z in zest.
**Expected behavior**: cursor...*Created by: ducks*
**Reproduction**: enter insert mode. type "this is some zest". use shift+space to drop back into normal mode. use gg to go back to the start of the line. use "tz" to find the z in zest.
**Expected behavior**: cursor goes to the z in zest
**Actual behavior**: cursor stays at the beginning of the line
**Build information**:
rustc 1.10.0-nightly (0667ae93f 2016-05-17)
707e6f106e542579dae23d069af1c312716b308e
Darwin Kernel Version 15.4.0, El Capitan 10.11.4, x86_64
This issue seems to be caused by this line: https://github.com/redox-os/sodium/blob/master/src/caret/movement.rs#L146
I tried printing out the n and dn and it seems like the n always came in as 1 and the dn is set at 0 so that if would never fire. I tried multiple lines and n still seemed to be 1.
I see that n is set here: https://github.com/redox-os/sodium/blob/master/src/core/exec.rs#L18
but have not tracked down where that comes from and what it does just yet.
next_ocur() also seems to just return the x that was passed to it: https://github.com/redox-os/sodium/blob/master/src/caret/movement.rs#L150
https://gitlab.redox-os.org/redox-os/sodium/-/issues/37Sort out the panics.2018-06-13T19:39:51ZJeremy SollerSort out the panics.*Created by: ticki*
Sodium currently is quite prone to panics. If you encounter a panic, add it here.
*Created by: ticki*
Sodium currently is quite prone to panics. If you encounter a panic, add it here.
https://gitlab.redox-os.org/redox-os/sodium/-/issues/36Termbox-based front-end.2018-07-03T15:15:35ZJeremy SollerTermbox-based front-end.*Created by: ticki*
*Created by: ticki*
https://gitlab.redox-os.org/redox-os/sodium/-/issues/35Accept a file argument2018-07-03T15:15:35ZJeremy SollerAccept a file argument`sodium file` should open a file.
`sodium file` should open a file.
https://gitlab.redox-os.org/redox-os/sodium/-/issues/34#![deny(missing_docs)]2018-07-03T15:15:35ZJeremy Soller#![deny(missing_docs)]*Created by: ticki*
*Created by: ticki*