stb_truetype-rs issueshttps://gitlab.redox-os.org/redox-os/stb_truetype-rs/-/issues2019-07-29T18:49:18Zhttps://gitlab.redox-os.org/redox-os/stb_truetype-rs/-/issues/24Please make bumps in minimum rust version a breaking change.2019-07-29T18:49:18ZLokathorPlease make bumps in minimum rust version a breaking change.I've been trying to get folks to take minimum supported rust more seriously, which has lead me here. I saw https://gitlab.redox-os.org/redox-os/stb_truetype-rs/issues/20 and I'm wondering if you'd be willing to at least make any bump in ...I've been trying to get folks to take minimum supported rust more seriously, which has lead me here. I saw https://gitlab.redox-os.org/redox-os/stb_truetype-rs/issues/20 and I'm wondering if you'd be willing to at least make any bump in minimum supported rust version be a breaking change release?https://gitlab.redox-os.org/redox-os/stb_truetype-rs/-/issues/23Fix FIXME in examples/fontname.rs2019-07-02T02:49:02ZFlávio J. SaraivaFix FIXME in examples/fontname.rsI noticed the FIXME in examples/fontname.rs.
name, a byte array, is being cast to a u16 array and read.
~~This will probably produce bad strings on machines with different endianess.~~
This can "blow up" on machines that can't read u16 ...I noticed the FIXME in examples/fontname.rs.
name, a byte array, is being cast to a u16 array and read.
~~This will probably produce bad strings on machines with different endianess.~~
This can "blow up" on machines that can't read u16 values on odd addresses.
To fix you just need to get the u16 values from the bytes, you already depend on the byteorder crate so here's a fix with it:
[fix_name16_alignment.txt](/uploads/566829e6d9cf1a42179421965b9f0152/fix_name16_alignment.txt)
EDIT - I misunderstood u16::from_be, it's only the alignmenthttps://gitlab.redox-os.org/redox-os/stb_truetype-rs/-/issues/22Can you provide the fonts/ directory in the crate?2019-03-19T20:10:55ZRobert-André MauchinCan you provide the fonts/ directory in the crate?It would be helpful in order to run the tests properly.It would be helpful in order to run the tests properly.https://gitlab.redox-os.org/redox-os/stb_truetype-rs/-/issues/14Add find_glyph_index benchmark regression test for `format=6` font2018-08-24T13:26:10ZAlex ButlerAdd find_glyph_index benchmark regression test for `format=6` fontWe have benchmark regression tests in benches/api.rs, that can be run with `cargo +nightly bench` & `cargo +nightly test --bench api`.
We're not currently testing format `6` `find_glyph_index` logic. We should add new one covering this ...We have benchmark regression tests in benches/api.rs, that can be run with `cargo +nightly bench` & `cargo +nightly test --bench api`.
We're not currently testing format `6` `find_glyph_index` logic. We should add new one covering this format, similar to how `find_glyph_index_gudea` covers format `4`.https://gitlab.redox-os.org/redox-os/stb_truetype-rs/-/issues/13Add find_glyph_index benchmark regression test for `format=0` font2018-08-24T13:23:47ZAlex ButlerAdd find_glyph_index benchmark regression test for `format=0` fontWe have benchmark regression tests in benches/api.rs, that can be run with `cargo +nightly bench` & `cargo +nightly test --bench api`.
We're not currently testing format `0` `find_glyph_index` logic. We should add new one covering this ...We have benchmark regression tests in benches/api.rs, that can be run with `cargo +nightly bench` & `cargo +nightly test --bench api`.
We're not currently testing format `0` `find_glyph_index` logic. We should add new one covering this format, similar to how `find_glyph_index_gudea` covers format `4`.