Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
tfs
tfs
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 38
    • Issues 38
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • redox-os
  • tfstfs
  • Issues
  • #87

Closed
Open
Opened Jan 24, 2019 by Ka-Hing Cheung@kahing

chashmap: add a version of upsert that returns the locked (mutable) reference

sometimes we want to change external values during an upsert (pseudo-code):

let mut is_one = false;
map.upsert(key, || { is_one = true; 1 }, |mut n| { n += 1; if n == 1 { is_one = true; } });

this code doesn't compile because is_one is mutably borrowed more than once.

It's possible to workaround this awkwardly:

let mut is_one1 = false;
let mut is_one2 = false;
map.upsert(key, || { is_one1 = true; 1 }, |mut n| { n += 1; if n == 1 { is_one2 = true; }});
// look at both is_one1 and is_one2

if there's a way to return a WriteGuard<K, V> with upsert that this can be solved more elegantly:

let is_one = {
    let n = map.upsert(key, || 1, |mut n| n+= 1);
    n == 1;
}
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: redox-os/tfs#87