From 9588161d4b676cd4b7039c821d33de91e70f6695 Mon Sep 17 00:00:00 2001 From: Tobias Markus <tobbi@mozilla-uk.org> Date: Tue, 21 Apr 2015 11:01:13 +0900 Subject: [PATCH] Fix coverity memory leak issues Signed-off-by: Tobias Markus <tobbi@mozilla-uk.org> --- timidity/timidity.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/timidity/timidity.c b/timidity/timidity.c index f7aba09b..262ccb1a 100644 --- a/timidity/timidity.c +++ b/timidity/timidity.c @@ -982,6 +982,10 @@ static int set_gus_patchconf(char *name, int line, { ctl->cmsg(CMSG_ERROR, VERB_NORMAL, "%s: line %d: Syntax error", name, line); +#ifdef SET_GUS_PATCHCONF_COMMENT + if(old_name != NULL) + free(old_name); +#endif return 1; } tone->name = safe_strdup(opts[0]); @@ -1034,6 +1038,13 @@ static int set_gus_patchconf(char *name, int line, { int err; if((err = set_gus_patchconf_opts(name, line, opts[j], tone)) != 0) + { +#ifdef SET_GUS_PATCHCONF_COMMENT + if(old_name != NULL) + free(old_name); +#endif + return err; + } return err; } #ifdef SET_GUS_PATCHCONF_COMMENT -- GitLab