Skip to content
Snippets Groups Projects
  1. Sep 01, 2020
  2. Aug 27, 2020
  3. Aug 02, 2020
  4. Jul 26, 2020
  5. Jul 25, 2020
    • bors's avatar
      Auto merge of #74670 - tmandry:issue-73818, r=matthewjasper · bb85981a
      bors authored
      Normalize bounds fully when checking defaulted types
      
      When checking that the default type for `<T as X>::Y` is valid in this example:
      
      ```
      trait X { type Y: PartialEq<<Self as X>::Y> }
      impl X for T { default type Y = S; }
      ```
      
      We will have to prove the bound `S: PartialEq<<T as X>::Y>`. In this case
      we want `<T as X>::Y` to normalize to `S`. This is valid because we are
      checking the default value specifically here. Add `<T as X>::Y = S` to the
      ParamEnv for normalization _of the bound we are checking_ only.
      
      Fixes #73818.
      
      ---
      
      I noticed that adding this to the env for bounds checking didn't break any tests. Not sure if this is because we can't rely on it to prove anything, or because of missing test coverage.
      
      r? @matthewjasper, @nikomatsakis
      bb85981a
    • bors's avatar
      Auto merge of #74760 - tmandry:roll, r=tmandry · d6953df1
      bors authored
      Update rustfmt and rls
      
      Closes #74080, #74081.
      
      rls changes:
      - deps: update racer and cargo
      
      rustfmt changes:
      - preparation for potential rustfmt 1.4.19 (#4283)
      - chore: backport 8157a3f0afe978d3e953420577f8344db7e905bf
      - deps: bump rustc-ap to v669
      - deps: bump rustc-ap-* to v668
      - deps: bump rustc-ap* to v666
      - Use correct span for match arms with the leading pipe and attributes (#3975)
      d6953df1
    • Tyler Mandry's avatar
      Update Cargo.lock · e193cb1f
      Tyler Mandry authored
      e193cb1f
    • Tyler Mandry's avatar
      Update rustfmt · 5e6380ad
      Tyler Mandry authored
      Changes:
      - preparation for potential rustfmt 1.4.19 (#4283)
      - chore: backport 8157a3f0afe978d3e953420577f8344db7e905bf
      - deps: bump rustc-ap to v669
      - deps: bump rustc-ap-* to v668
      - deps: bump rustc-ap* to v666
      - Use correct span for match arms with the leading pipe and attributes (#3975)
      5e6380ad
    • Tyler Mandry's avatar
      Update rls · c6526b3d
      Tyler Mandry authored
      Changes:
      - deps: update racer and cargo
      c6526b3d
    • Tyler Mandry's avatar
      e35d2867
    • Tyler Mandry's avatar
    • bors's avatar
      Auto merge of #74246 - GuillaumeGomez:cleanup-e0719, r=Dylan-DPC · 8cb94fc5
      bors authored
      Clean up E0719 explanation
      
      r? @Dylan-DPC
      8cb94fc5
    • bors's avatar
      Auto merge of #74687 - estebank:bracketless-turbofish, r=matthewjasper · f06e8e15
      bors authored
      Detect turbofish missing surrounding angle brackets
      
      Fix #74065.
      f06e8e15
    • Philippe Nadon's avatar
      Miri: rename "undef" to "uninit" · ef9c4f5c
      Philippe Nadon authored
      renamed Allocation::check_defined_and_ptr to Allocation::check_init_and_ptr
      
      renamed Allocation::check_defined_and_ptr to Allocation::check_init_and_ptr
      
      in src/librustc_middle/mir/interpret/allocation.rs
      
      renamed Allocation::is_defined and Allocation::check_defined, fixed documentation
      
      renamed Allocation::is_defined and Allocation::check_defined to is_init and check_init respectively.
      
      Fixed documentation so it correctly refers to "initialization" instead of "defined"-ness
      
      renamed Allocation::mark_definedness
      
      renamed Allocation::mark_definedness to Allocation::mark_init
      
      Renamed new_state parameter in Allocation::mark_init
      
      Renamed new_state to is_init, as the latter is more descriptive.
      
      renamed functions in AllocationDefinedness
      
      renamed AllocationDefinedness::all_bytes_undef and AllocationDefinedness::mark_compressed_undef_range to no_bytes_init and mark_compressed_init_range respectively.
      
      renamed AllocationDefinedness to InitMaskCompressed
      
      renamed Immediate::to_scalar_or_undef
      
      renamed to to_scalar_or_uninit
      
      fixed comment references to "undef"
      
      Changed comments referring to "undef" and "definedness" to "initialization" and "initialization state" in src/librustc_mir/interpret/memory.rs and src/librustc_middle/mir/interpret/allocation.rs
      
      changed references to "undef" in comments and a variable
      
      Changed some comments referring to "undef" to use "uninitialized" instead. Also changed a variable from "undef_end" to "uninit_end".
      All changes were made within src/librustc_middle/mir/interpret/allocation.rs.
      
      Changed more comments referring to undef
      
      Changed comments to use "uninitialized" instead of "undef" in src/librustc_middle/mir/interpret/allocation.rs.
      ef9c4f5c
    • bors's avatar
      Auto merge of #74510 - LukasKalbertodt:fix-range-from-index-panic, r=hanna-kruppe · fe08fb7b
      bors authored
      Fix panic message when `RangeFrom` index is out of bounds
      
      Before, the `Range` method was called with `end = slice.len()`. Unfortunately, because `Range::index` first checks the order of the indices (start has to be smaller than end), an out of bounds index leads to `core::slice::slice_index_order_fail` being called. This prints the message 'slice index starts at 27 but ends at 10', which is worse than 'index 27 out of range for slice of length 10'. This is not only useful to normal users reading panic messages, but also for people inspecting assembly and being confused by `slice_index_order_fail` calls.
      
      You can see the produced assembly [here](https://rust.godbolt.org/z/GzMGWf) and try on Playground [here](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=aada5996b2f3848075a6d02cf4055743). (By the way. this is only about which panic function is called; I'm pretty sure it does not improve anything about performance).
      fe08fb7b
    • Takayuki Nakata's avatar
      Fix FP `useless_conversion` · c81bbd05
      Takayuki Nakata authored
      Fix #5833.
      c81bbd05
    • bors's avatar
      Auto merge of #74488 - CAD97:layout_for_value_raw, r=hanna-kruppe · 037d8e74
      bors authored
      re-add Layout::for_value_raw
      
      Tracking issue: #69835
      
      This was accidentally removed in #70362 56cbf2f2.
      Originally added in #69079.
      037d8e74
    • bors's avatar
      Auto merge of #74741 - aticu:master, r=jonas-schievink · 73ca84df
      bors authored
      Improve documentation of `String::from_raw_parts`
      73ca84df
    • aticu's avatar
      Document UTF-8 validity of String::from_raw_parts · 44d8b4c8
      aticu authored
      44d8b4c8
    • aticu's avatar
      Fix wrong name in `String::from_raw_parts` docs · e7949bc2
      aticu authored
      e7949bc2
    • Aaron Hill's avatar
      116ad51c
    • bors's avatar
      Auto merge of #74652 - poliorcetics:clarify-vec-drain-doc, r=jyn514 · 0e11fc80
      bors authored
      Improve the documentation for Vec::drain
      
      Fixes #73844.
      
      @rusbot modify labels: A-collections, C-enhancement, T-doc, T-libs
      0e11fc80
    • bors's avatar
      Auto merge of #74017 - poliorcetics:where-keyword, r=jyn514 · c4e17347
      bors authored
      Document the where keyword
      
      Partial fix of #34601 (and last PR for it :tada:).
      
      This documents the `where` keyword.
      
      @rustbot modify labels: T-doc,C-enhancement
      c4e17347
    • 16yuki0702's avatar
      Fix rustc docs typo. · 04b2deb3
      16yuki0702 authored
      04b2deb3
  6. Jul 24, 2020
Loading