Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
R
relibc
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Peter Limkilde Svendsen
relibc
Commits
92b56f3f
Verified
Commit
92b56f3f
authored
1 year ago
by
Jeremy Soller
Browse files
Options
Downloads
Patches
Plain Diff
Format
parent
99f097cf
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/header/grp/mod.rs
+60
-16
60 additions, 16 deletions
src/header/grp/mod.rs
src/header/pthread/tls.rs
+6
-1
6 additions, 1 deletion
src/header/pthread/tls.rs
with
66 additions
and
17 deletions
src/header/grp/mod.rs
+
60
−
16
View file @
92b56f3f
...
...
@@ -206,11 +206,17 @@ fn parse_grp(line: String, destbuf: Option<DestBuffer>) -> Result<OwnedGrp, Erro
// MT-Unsafe race:grgid locale
#[no_mangle]
pub
unsafe
extern
"C"
fn
getgrgid
(
gid
:
gid_t
)
->
*
mut
group
{
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
ptr
::
null_mut
()
};
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
ptr
::
null_mut
();
};
for
line
in
BufReader
::
new
(
db
)
.lines
()
{
let
Ok
(
line
)
=
line
else
{
return
ptr
::
null_mut
()
};
let
Ok
(
grp
)
=
parse_grp
(
line
,
None
)
else
{
return
ptr
::
null_mut
()
};
let
Ok
(
line
)
=
line
else
{
return
ptr
::
null_mut
();
};
let
Ok
(
grp
)
=
parse_grp
(
line
,
None
)
else
{
return
ptr
::
null_mut
();
};
if
grp
.reference.gr_gid
==
gid
{
return
grp
.into_global
();
...
...
@@ -223,12 +229,18 @@ pub unsafe extern "C" fn getgrgid(gid: gid_t) -> *mut group {
// MT-Unsafe race:grnam locale
#[no_mangle]
pub
unsafe
extern
"C"
fn
getgrnam
(
name
:
*
const
c_char
)
->
*
mut
group
{
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
ptr
::
null_mut
()
};
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
ptr
::
null_mut
();
};
for
line
in
BufReader
::
new
(
db
)
.lines
()
{
let
Ok
(
line
)
=
line
else
{
return
ptr
::
null_mut
()
};
let
Ok
(
line
)
=
line
else
{
return
ptr
::
null_mut
();
};
let
Ok
(
grp
)
=
parse_grp
(
line
,
None
)
else
{
return
ptr
::
null_mut
()
};
let
Ok
(
grp
)
=
parse_grp
(
line
,
None
)
else
{
return
ptr
::
null_mut
();
};
// Attempt to prevent BO vulnerabilities
if
strncmp
(
...
...
@@ -253,11 +265,21 @@ pub unsafe extern "C" fn getgrgid_r(
buflen
:
usize
,
result
:
*
mut
*
mut
group
,
)
->
c_int
{
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
ENOENT
};
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
ENOENT
;
};
for
line
in
BufReader
::
new
(
db
)
.lines
()
{
let
Ok
(
line
)
=
line
else
{
return
EINVAL
};
let
Ok
(
mut
grp
)
=
parse_grp
(
line
,
Some
(
DestBuffer
{
ptr
:
buffer
as
*
mut
u8
,
len
:
buflen
}))
else
{
return
EINVAL
};
let
Ok
(
mut
grp
)
=
parse_grp
(
line
,
Some
(
DestBuffer
{
ptr
:
buffer
as
*
mut
u8
,
len
:
buflen
,
}),
)
else
{
return
EINVAL
;
};
if
grp
.reference.gr_gid
==
gid
{
*
result_buf
=
grp
.reference
;
...
...
@@ -279,11 +301,21 @@ pub unsafe extern "C" fn getgrnam_r(
buflen
:
usize
,
result
:
*
mut
*
mut
group
,
)
->
c_int
{
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
ENOENT
};
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
ENOENT
;
};
for
line
in
BufReader
::
new
(
db
)
.lines
()
{
let
Ok
(
line
)
=
line
else
{
return
EINVAL
};
let
Ok
(
mut
grp
)
=
parse_grp
(
line
,
Some
(
DestBuffer
{
ptr
:
buffer
as
*
mut
u8
,
len
:
buflen
}))
else
{
return
EINVAL
};
let
Ok
(
mut
grp
)
=
parse_grp
(
line
,
Some
(
DestBuffer
{
ptr
:
buffer
as
*
mut
u8
,
len
:
buflen
,
}),
)
else
{
return
EINVAL
;
};
if
strncmp
(
grp
.reference.gr_name
,
...
...
@@ -307,13 +339,19 @@ pub unsafe extern "C" fn getgrent() -> *mut group {
let
mut
line_reader
=
&
mut
*
LINE_READER
.get
();
if
line_reader
.is_none
()
{
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
ptr
::
null_mut
()
};
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
ptr
::
null_mut
();
};
*
line_reader
=
Some
(
BufReader
::
new
(
db
)
.lines
());
}
if
let
Some
(
lines
)
=
line_reader
.deref_mut
()
{
let
Some
(
line
)
=
lines
.next
()
else
{
return
ptr
::
null_mut
()
};
let
Ok
(
line
)
=
line
else
{
return
ptr
::
null_mut
()
};
let
Some
(
line
)
=
lines
.next
()
else
{
return
ptr
::
null_mut
();
};
let
Ok
(
line
)
=
line
else
{
return
ptr
::
null_mut
();
};
if
let
Ok
(
grp
)
=
parse_grp
(
line
,
None
)
{
return
grp
.into_global
();
...
...
@@ -335,7 +373,9 @@ pub unsafe extern "C" fn endgrent() {
#[no_mangle]
pub
unsafe
extern
"C"
fn
setgrent
()
{
let
mut
line_reader
=
&
mut
*
LINE_READER
.get
();
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
};
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
;
};
*
line_reader
=
Some
(
BufReader
::
new
(
db
)
.lines
());
}
...
...
@@ -354,9 +394,13 @@ pub unsafe extern "C" fn getgrouplist(
// FIXME: This API probably expects the group database to already exist in memory, as it
// doesn't seem to have any documented error handling.
let
Ok
(
user
)
=
(
crate
::
c_str
::
CStr
::
from_ptr
(
user
)
.to_str
())
else
{
return
0
};
let
Ok
(
user
)
=
(
crate
::
c_str
::
CStr
::
from_ptr
(
user
)
.to_str
())
else
{
return
0
;
};
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
0
;
};
let
Ok
(
db
)
=
File
::
open
(
c_str!
(
"/etc/group"
),
fcntl
::
O_RDONLY
)
else
{
return
0
;
};
let
mut
groups_found
:
c_int
=
0
;
...
...
This diff is collapsed.
Click to expand it.
src/header/pthread/tls.rs
+
6
−
1
View file @
92b56f3f
...
...
@@ -104,7 +104,12 @@ static NEXTKEY: Cell<pthread_key_t> = Cell::new(1);
pub
(
crate
)
unsafe
fn
run_all_destructors
()
{
for
(
key
,
Record
{
data
})
in
VALUES
.take
()
{
let
Some
(
&
Dtor
{
destructor
:
Some
(
dtor
)
})
=
KEYS
.lock
()
.get
(
&
key
)
else
{
continue
};
let
Some
(
&
Dtor
{
destructor
:
Some
(
dtor
),
})
=
KEYS
.lock
()
.get
(
&
key
)
else
{
continue
;
};
dtor
(
data
);
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment