Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
C
chashmap
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 11
    • Issues 11
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • redox-os
  • chashmap
  • Merge Requests
  • !4

Open
Opened Mar 19, 2020 by icy@icy
  • Report abuse
Report abuse

implement fix and test for #9

  • Overview 2
  • Commits 2
  • Changes 3

Implement a (crude) fix for issue #9 as well as adding the given example code to the test suite.

This should be considered a preliminary PR and I recommend that improvements be made before merging. In particular, testing the bug against regressions requires adding a hash() method to the public API for CHashMap, which is suboptimal.

Also worth improvement is the logic used in scan_mut() and scan().

This code is not performance critical as it is only used in the (rare) case where the bug would be triggered. However, there is significant code duplication at the moment.

Edited Mar 19, 2020 by icy
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: redox-os/chashmap!4
Source branch: scan_fix