Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • C coreutils
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 10
    • Issues 10
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • redox-osredox-os
  • coreutils
  • Merge requests
  • !207

dd: Fix "warning: trait objects without an explicit `dyn` are deprecated"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Alex DeLorenzo requested to merge alexdelorenzo/coreutils:patch-1 into master Sep 14, 2020
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

When building coreutils, the following warnings will be emitted:

warning: trait objects without an explicit `dyn` are deprecated                                                              
  --> src/bin/dd.rs:85:24                                                                                                    
   |                                                                                                                         
85 |     let mut input: Box<Read> = match parser.found("if") {                                                               
   |                        ^^^^ help: use `dyn`: `dyn Read`                                                                 
   |                                                                                                                         
   = note: `#[warn(bare_trait_objects)]` on by default                                                                       
                                                                                                                             
warning: trait objects without an explicit `dyn` are deprecated                                                              
  --> src/bin/dd.rs:97:25                                                                                                    
   |                                                                                                                         
97 |     let mut output: Box<Write> = match parser.found("of") {                                                             
   |                         ^^^^^ help: use `dyn`: `dyn Write`                                                              
                                                                                                                             
warning: 2 warnings emitted

This PR adds explicit dyn keywords before trait objects.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: patch-1