GitLab

Code hygiene

See merge request !72

Signed-off-by: Wren Turkal <wt@penguintechs.org>

Signed-off-by: Wren Turkal <wt@penguintechs.org>

Add pci vendor specific capability.

See merge request !71

Add more structure cli to pcid.

See merge request !67

This change adds a structopt commandline interface to the pcid tool.
This add some help for the arguments that pcid takes.
Signed-off-by: Wren Turkal <wt@penguintechs.org>

Ignore all target directories.

See merge request !70

Fix buggy assertion in pcid capability parser.

See merge request !69

Signed-off-by: Wren Turkal <wt@penguintechs.org>

When working in an IDE like vscode, it uses rust infrastructure to
check the code, which results in "target" folders in the base of
the crates I am working on. For example, if I am working on pcid
code, I get a "target" folder in the pcid folder. This change
causes git to ignore all those target directories.
Signed-off-by: Wren Turkal <wt@penguintechs.org>

The pcid capability parsing code has an assertion that checks for dword
alignment. Unfortunately, the check was previously checking for
alignment to qwords. This fixes that.

I found this issue by using qemu to emulate adding different pci
devices. I managed to come across a device that had a capability
aligned on dword, but not qword. That exposed the bug.
Signed-off-by: Wren Turkal <wt@penguintechs.org>

Fixed PCI bus scan to scan bus 0xFF.

See merge request !68

Previously, the PCI bus scan was skipping bus 0xFF. Now it does not.
I used a match expression to make sure that all cases are accounted for.

I also changed the PCI dev scan and PCI func scan to use a match
expression in a similar way to make sure all cases are account. While
this is functionally the same as before, the match expression will not
allow unhandled cases and should be easier to read and make it harder
to introduce bugs.
Signed-off-by: Wren Turkal <wt@penguintechs.org>

Remove unsafe declarations.

See merge request !65

The removed unsafe statements were identified by rustc as unneeded during
compilation.
Signed-off-by: Wren Turkal <wt@penguintechs.org>

Support xHCs that only support 32-bit physical addresses.

See merge request !64

Improved PCI capability parsing.

See merge request !63

Revert "Enable ahcid interrupts"

See merge request !62

This reverts commit f00a0494.

only cleanup left...

Note that by writing submission, I'm referring to blocking until a
submission queue has more entries available. The command completion
handling is already async.