Skip to content

Make 'users' field optional for config (e.g. for initfs)

Mikhail Chystsiakou requested to merge mich/installer:master into master

My build failed with following errors:

[mich@mich-tp redox]$ PREFIX_RUSTC=1 PREFIX_BINARY=0 make iso
rm -f build/libkernel_live.a
rm -rf build/initfs_live
mkdir -p build/initfs_live
export PATH="/home/mich/rust/redox/prefix/x86_64-unknown-redox/relibc-install/bin:$PATH" && \
cargo run --manifest-path installer/Cargo.toml -- --cookbook=cookbook -c initfs_live.toml build/initfs_live/
   Compiling redox_installer v0.2.3 (/home/mich/rust/redox/installer)
    Finished dev [unoptimized + debuginfo] target(s) in 4.41s
     Running `installer/target/debug/redox_installer --cookbook=cookbook -c initfs_live.toml build/initfs_live/`
installer: initfs_live.toml: failed to decode: missing field `users`
make: *** [mk/initfs.mk:21: build/initfs_live.tag] Error 1

@MggMuggins said

Idk if there are supposed to be users on the initfs. I wrote part of that code for the installer and I've been messing with init, and I don't think it's required. I might check the history and see if that field became non-optional at some point

so I made 'users' field optional and build proceeds.

P.S. It worked commit ago (71335925)

Merge request reports