~/h expands to ~/home

Created by: aeosynth

mkdir ~/h
~/h<Tab> # ~/home/james/h

Created by: zwieberl

For me this happens only, if there exists a directory inside ~ that starts with h as well: if there is none ~/h<Tab> -> Nothing happens if there is e.g. "htest/" inside my home: ~/h<Tab> -> ~/home/zwieberl/htest

Also this happens only for h. ~/D<Tab> works as expected.

Am looking into this now

Created by: zwieberl

I think this might fix it:

diff --git a/src/shell/completer.rs b/src/shell/completer.rs
index 1f8f37c..87277f8 100644
--- a/src/shell/completer.rs
+++ b/src/shell/completer.rs
@@ -76,7 +76,7 @@ impl Completer for IonFileCompleter {
                     // search pattern begins, and re-use that index to slice the completions so
                     // that we may re-add the tilde character with the completion that follows.
                     if let Some(completion) = iterator.next() {
-                        if let Some(e_index) = completion.find(search) {
+                        if let Some(e_index) = completion.rfind(search) {
                             completions.push(escape(&[tilde, &completion[e_index..]].concat()));
                             for completion in iterator {
                                 let expanded = &completion[e_index..];

In addition to this, I think it's about time we thought about how we will go about supporting custom completions and application-specific completions.

Created by: zwieberl

Yes, although this probably deserves its own issue then?