Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • ion ion
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 86
    • Issues 86
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • redox-osredox-os
  • ionion
  • Merge requests
  • !1190

Make arrays able to nest

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tom Almeida requested to merge Tommoa/ion:feature/allow-nested-arrays into master Mar 17, 2020
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 5

Prior to this commit, the following type was considered invalid: [[float]]

Of course, sometimes it is helpful to have arrays within arrays, and as such, this patch allows for nested arrays. To do this, the array types in Primitive have all been converted to a Primitive::Array type, that holds a Box<> to another Primitive. There is - of course - a slight performance penalty to be expected with moving to using another Box for arrays, however after having run the benchmarks, the difference appears to be negligible.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/allow-nested-arrays