Skip to content

Moving the glob parser

Michael Aaron Murphy requested to merge mgmoens:globtest into master

Created by: mgmoens

Problem:Globbing during shell expansion (see https://github.com/redox-os/ion/issues/258)

Solution: I added an extra param to the Normal token which designates it as a normal token that's globable or not. Changes introduced by this pull request:

  • Globbing gets moved and probably (isn't) yet parsed 100% correctly. I'm just submitting this PR so I can get in touch with contributors and notify other people of my attempt at trying to fix this.

Drawbacks:

Wildcards during quotes don't parse correctly.

TODOs: [what is not done yet.]

Make sure wildcards in quotes get parsed as text (if this happened during the previous version).

Fixes: [what issues this fixes.] https://github.com/redox-os/ion/issues/258 State: [the state of this PR, e.g. WIP, ready, etc.] Ready for review Blocking/related: [issues or PRs blocking or being related to this issue.]

Other: The author isn't all that used to programming in Rust.

Merge request reports