Skip to content

Fixed job arguments expanding to empty string

Michael Aaron Murphy requested to merge huntergoldstein:probably_shouldnt_touch_unrelated_code into master

Created by: huntergoldstein

Changes introduced by this pull request:

  • If a job argument expands to the empty string, return an array containing the empty string instead.
  • Added a regression test w.r.t. job expansion

Fixes: Closes #345 (closed) (again).

I wonder if it would be helpful to make a distinction inside Ion's code-base between string and array values. I.e. Array becomes Value, and Value becomes an enum like:

enum Value {
  String(SmallString<...>),
  Array(SmallVec<...>),
}

Though we probably can't use SmallVec; it would have to be Vec (I think).

Merge request reports