Skip to content

Merge `unescape` methods

Michael Aaron Murphy requested to merge AgustinCB:merge-unescape into master

Created by: AgustinCB

Problem: There's two unescape methods, doing closely related things.

Solution: Just remove the one with less features. It also happens to accept references as argument, as opposed to the other one, so even better.

Changes introduced by this pull request:

  • Remove unescape on pattern.
  • Use the one on strings everywhere.
  • Because pattern just had four lines of code after that, of a type that doesn't make sense outside Method, so I just moved that type to mod and removed the file.

Drawbacks: Not exactly a drawback, as this wasn't a feature to start with, but I'm silently eating the unescape errors on a couple places.

Fixes: #604 (closed)

State: Ready for review. Feel free to merge if no comment.

Merge request reports