Skip to content

Ping

Guillaume Gielly requested to merge (removed):ping into master

Some improvements to the ping utility, focusing on functionality, code structure, and maintainability :

Command-Line Parsing

  • Integrated clap for command-line argument parsing.
  • Added support for the -t TTL option but currently commented out due to limitations in the netstack and the implementation.

Code Refactoring

  • Ping Struct :
    • replaced the Vec used for tracking pending pings with a BTreeMap for more efficient lookups and time-based operations.
  • Packet loss calculation :
    • refactored the packet_loss_percentage calculation for improved readability and accuracy.
  • General cleanup :
    • removed outdated or redundant comments.
    • simplified logic in various parts of the code.

Thank you !

Edited by Guillaume Gielly

Merge request reports