Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • O orbital
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • redox-osredox-os
  • orbital
  • Merge requests
  • !38

Avoid panics where possible

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Andrew Mackenzie requested to merge andrewdavidmackenzie/orbital:avoid_panics_where_possible into master Mar 15, 2023
  • Overview 20
  • Commits 8
  • Pipelines 2
  • Changes 5

Fixes #42

This MR removes any unwraps and expects (except in tests) that were in the orbital code that would have caused it to possibly panic without logging an error and attempting to handle it.

It also factors out some small functions of repeated code (which I see elsewhere and maybe used further later).

I leave this as DRAFT because I have not been able to test very well due to mouse issues in qemu I have had.

I have selected "Squash commits when merge request is accepted"

Edited Mar 17, 2023 by Andrew Mackenzie
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: avoid_panics_where_possible