Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P pkgar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • redox-os
  • pkgar
  • Merge requests
  • !6

Keys lib

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged SamwiseFilmore requested to merge keys-lib-cheap-header into master Aug 11, 2020
  • Overview 0
  • Commits 9
  • Changes 26

The primary change here is moving pkgar-keys into this repository. However, I also refactored the existing pkgar crate to be two crates, pkgar-core is no-std and contains the basic type/trait definitions for various package actions, and pkgar requires std and provides all the filesystem access stuff. There are numerous refactorings in here:

  • Errors got some changes, and uses the thiserror crate to derive the error trait and some from impls. I also pulled in UserFacingError for displaying errors (especially errors with source attributes) to the user. This could probably use some improvement, but it was easy.
  • PackageSrc had been an enum, but I needed to split up the bytes implementation from the file implementation so that it could be used in pkgar-core. It's now a trait that provides most of the methods needed to read package info. It can definitely still handle optimization, but I think it's a reasonable design. Some more high-level APIs should probably be added to make it more possible to reduce network calls if a PackageSrc was implemented on a network location.
  • I also modified the tests a bit, but they pass.

Please let me know anything that you notice, I'm happy to implement improvements before merge.

keys-lib can be deleted, this branch is based on it.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: keys-lib-cheap-header