Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • R redoxfs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • redox-osredox-os
  • redoxfs
  • Merge requests
  • !51

Clippy fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open joeftiger requested to merge joeftiger/redoxfs:clippy-fix into master Jun 27, 2021
  • Overview 3
  • Commits 11
  • Pipelines 2
  • Changes 13

I fixed some things that clippy is not happy about either. Mainly I removed redundant code like.

There are at least 2 things left like:

  • Rewriting if chain with match in mount.rs.
    I don't really know how one would move that to a match unless one uses ranges like 1..isize::MAX => {...}.
  • Handling the read amount in mount.rs with Read::read_exact. According to clippy it's more of an error than just a warning.
    I am unsure whether to "fix" this as I am not too familiar with the surrounding code. It looks okay to me to change it however.
Edited Jun 27, 2021 by joeftiger
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: clippy-fix