Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
R
relibc
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 33
    • Issues 33
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 19
    • Merge Requests 19
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • redox-os
  • relibc
  • Merge Requests
  • !324

Open
Opened Dec 06, 2020 by coolreader18@coolreader18
  • Report abuse
Report abuse

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://gitlab.redox-os.org/coolreader18/relibc.git" "fix-tcsetattr"
git checkout -b "coolreader18/relibc-fix-tcsetattr" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "master"
git merge --no-ff "coolreader18/relibc-fix-tcsetattr"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Handle TCSETSW and TCSETSF in ioctl

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Fixes #168.

I noticed that dup_{read,write} might have some UB, so I added a TODO comment about it. I think to fix that todo, there would have to be changes across here, redox-syscall, and the kernel to pass around pointers rather than references, but I figure you gotta start somewhere.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: redox-os/relibc!324
Source branch: fix-tcsetattr