Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • seahash seahash
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • redox-osredox-os
  • seahashseahash
  • Merge requests
  • !2

stream: Fix chunking sensitivity.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tom Almeida requested to merge fix_chunking into master Jan 29, 2020
  • Overview 4
  • Commits 2
  • Pipelines 2
  • Changes 4

Fixes #1 (closed).

This is a breaking change that will cause the major version to be bumped.

  • Rewrite SeaHasher to use its own inner state instead of the one in buffer.rs
  • Add tests for chunking for stream hashing
  • Add tests for ensuring the same result for streaming and block hashing
  • Add benchmark for stream hashing
  • Change ... to ..= in buffer.rs

Benchmark change:

  • Before: test gigabyte_stream ... bench: 146,492,395 ns/iter (+/- 3,035,585)
  • After: test gigabyte_stream ... bench: 148,758,785 ns/iter (+/- 2,188,461)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_chunking