Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • seahash seahash
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • redox-osredox-os
  • seahashseahash
  • Merge requests
  • !6

benches: Use criterion

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Joonas Koivunen requested to merge koivunej/seahash:use_criterion into master Nov 16, 2020
  • Overview 2
  • Commits 7
  • Pipelines 2
  • Changes 3

Me failing to run enough benchmarks in !5 (merged) lead me to think that perhaps with criterion the lack of change in perf might be easier to spot. Testing !5 (merged) on these commits with similar background noise does yield the No change in performance detected..

Obvious cons with criterion is that it does add even more compilation time to this previously fast to compile crate.

Pros include no longer requiring nightly usage.

Instead of a single long bench for each {buffer,stream} there are now a number of smaller sizes (8-16384 bytes) which are benchmarked. The choice of the buckets was quite arbitary.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: use_criterion