Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • termion termion
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 65
    • Issues 65
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • redox-osredox-os
  • termiontermion
  • Merge requests
  • !153

Format, update numtoa; Avoid panicking & allocating in event parsing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Jonathan Schleußer requested to merge ParadoxSpiral/termion:master into master Jan 12, 2019
  • Overview 3
  • Commits 4
  • Pipelines 3
  • Changes 28

I'm not a fan of how the code to avoid allocations looks like, but I haven't found another way. I'm also not 100% sure that it is correct, but all the tests are passing, so that's a good sign.

Edit: The major reason that panicking in event parsing is bad, is that the enduser has to guarantee that a CSI sequence is complete, which they can't do without basically replicating the event parser.

Edited Jan 12, 2019 by Jonathan Schleußer
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master